LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aakash Hemadri <aakashhemadri123@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	linux-staging@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] staging: rtl8732bs: Fix sparse warnings
Date: Tue, 17 Aug 2021 19:54:11 +0200	[thread overview]
Message-ID: <YRv3w4y3r84mBjrU@kroah.com> (raw)
In-Reply-To: <cover.1629134725.git.aakashhemadri123@gmail.com>

On Mon, Aug 16, 2021 at 11:00:41PM +0530, Aakash Hemadri wrote:
> This patchset fixes the below sparse warnings
> 
> rtw_security.c:72:50: warning: incorrect type in assignment (different base types)
> rtw_security.c:72:50:    expected restricted __le32 [usertype]
> rtw_security.c:72:50:    got unsigned int
> rtw_security.c:80:50: warning: incorrect type in assignment (different base types)
> rtw_security.c:80:50:    expected restricted __le32 [usertype]
> rtw_security.c:80:50:    got unsigned int
> rtw_security.c:124:33: warning: cast to restricted __le32
> rtw_security.c:509:58: warning: incorrect type in assignment (different base types)
> rtw_security.c:509:58:    expected restricted __le32 [usertype]
> rtw_security.c:509:58:    got unsigned int
> rtw_security.c:517:58: warning: incorrect type in assignment (different base types)
> rtw_security.c:517:58:    expected restricted __le32 [usertype]
> rtw_security.c:517:58:    got unsigned int
> rtw_security.c:621:41: warning: cast to restricted __le32
> 
> This can be applied cleanly on next-20210816, and is compile tested.
> 
> Aakash Hemadri (2):
>   staging: rtl8732bs: incorrect type in assignment
>   staging: rtl8723bs: cast to restricted __le32
> 
>  rtw_security.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

This series does not apply to my tree at all.  Please fix up and rebase
and resubmit, after reading the mailing list archives for others that
have attempted do do this type of work in the past for this issue.

It is not a trivial change that is needed...

thanks,

greg k-h

  parent reply	other threads:[~2021-08-17 17:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 17:30 Aakash Hemadri
2021-08-16 17:30 ` [PATCH 1/2] staging: rtl8732bs: incorrect type in assignment Aakash Hemadri
2021-08-16 17:30 ` [PATCH 2/2] staging: rtl8723bs: fix cast to restricted __le32 Aakash Hemadri
2021-08-17 17:54 ` Greg Kroah-Hartman [this message]
2021-08-17 19:10   ` [PATCH 0/2] staging: rtl8732bs: Fix sparse warnings Fabio M. De Francesco
2021-08-18  4:42     ` Aakash Hemadri
2021-08-18  4:40   ` Aakash Hemadri
2021-08-16 17:35 Aakash Hemadri
2021-08-16 18:48 ` Fabio M. De Francesco
2021-08-18  5:58   ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRv3w4y3r84mBjrU@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aakashhemadri123@gmail.com \
    --cc=bjorn@helgaas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --subject='Re: [PATCH 0/2] staging: rtl8732bs: Fix sparse warnings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).