LKML Archive on
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
To: "Fabio M. De Francesco" <>
Cc: Larry Finger <>,
	Phillip Potter <>,
	Martin Kaiser <>,
	Michael Straube <>,,
Subject: Re: [PATCH v2 2/3] staging: r8188eu: Remove code depending on NAT25_LOOKUP
Date: Tue, 17 Aug 2021 19:55:36 +0200	[thread overview]
Message-ID: <YRv4GLL0BsMm/> (raw)
In-Reply-To: <>

On Mon, Aug 16, 2021 at 07:51:38PM +0200, Fabio M. De Francesco wrote:
> Remove all the code related to the management of the NAT25_LOOKUP
> method in nat25_db_handle(). The only function that used that method was
> the now deleted nat25_handle_frame(). Remove the NAT25_LOOKUP entry from
> the NAT25_METHOD enum because it is not anymore used everywhere else in
> the code of the driver.
> Signed-off-by: Fabio M. De Francesco <>
> ---
> v2: Patch rebased against the latest Greg K-H's tree.
>  drivers/staging/r8188eu/core/rtw_br_ext.c    | 112 -------------------
>  drivers/staging/r8188eu/include/rtw_br_ext.h |   1 -
>  2 files changed, 113 deletions(-)

This change adds a build warning, which is not allowed.

Please merge this, and the 3/3 patch into a single change, so that it
all is removed together, causing no build warnings at any point in time.


greg k-h

  parent reply	other threads:[~2021-08-17 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 17:51 Fabio M. De Francesco
2021-08-16 19:52 ` Michael Straube
2021-08-17 17:55 ` Greg Kroah-Hartman [this message]
2021-08-17 20:21   ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRv4GLL0BsMm/ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 2/3] staging: r8188eu: Remove code depending on NAT25_LOOKUP' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).