LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "avagin@gmail.com" <avagin@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: 'Bui Quang Minh' <minhquangbui99@gmail.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
	"dsahern@kernel.org" <dsahern@kernel.org>,
	"willemb@google.com" <willemb@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"alexander@mihalicyn.com" <alexander@mihalicyn.com>,
	"lesedorucalin01@gmail.com" <lesedorucalin01@gmail.com>
Subject: Re: [PATCH v2 1/2] udp: UDP socket send queue repair
Date: Tue, 17 Aug 2021 09:22:20 -0700	[thread overview]
Message-ID: <YRviPJwrnuh9Nn35@gmail.com> (raw)
In-Reply-To: <29dc7ac9781344f1a57e16c14900a7da@AcuMS.aculab.com>

On Fri, Aug 13, 2021 at 01:00:12PM +0000, David Laight wrote:
> From: Bui Quang Minh
> > Sent: 13 August 2021 12:08
> ...
> > The reason we want to dump the packet in send queue is to make to state of the
> > application consistent. The scenario is that when an application sends UDP
> > packets via UDP_CORK socket or with MSG_MORE, CRIU comes and checkpoints the
> > application. If we drop the data in send queue, when application restores, it
> > sends some more data then turns off the cork and actually sends a packet. The
> > receiving side may get that packet but it's unusual that the first part of that
> > packet is missing because we drop it. So we try to solve this problem with some
> > help from the Linux kernel.
> 
> Patient: It hurts if I do xxx.
> Doctor: Don't do xxx then.
> 
> It has to be more efficient to buffer partial UDP packets
> in userspace and only send when all the packet is available.

You are right. It can be more efficient, but we don't have controls over
user-space processes, and they can do whatever the kernel allows them to
do.

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)

  reply	other threads:[~2021-08-17 16:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 15:45 Bui Quang Minh
2021-08-11 16:14 ` Eric Dumazet
2021-08-12 13:46   ` Bui Quang Minh
2021-08-12 15:51     ` Eric Dumazet
2021-08-13 11:08       ` Bui Quang Minh
2021-08-13 13:00         ` David Laight
2021-08-17 16:22           ` avagin [this message]
2021-08-16 14:35         ` Willem de Bruijn
2021-08-16 14:38 ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRviPJwrnuh9Nn35@gmail.com \
    --to=avagin@gmail.com \
    --cc=David.Laight@aculab.com \
    --cc=alexander@mihalicyn.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lesedorucalin01@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minhquangbui99@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    --cc=yoshfuji@linux-ipv6.org \
    --subject='Re: [PATCH v2 1/2] udp: UDP socket send queue repair' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).