LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH v2 net-next 1/1] ptp_ocp: use bits.h macros for all masks
Date: Tue, 17 Aug 2021 19:46:07 +0300 [thread overview]
Message-ID: <YRvnz01sPpHMnkqQ@smile.fi.intel.com> (raw)
In-Reply-To: <20210817064814.13c57002@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, Aug 17, 2021 at 06:48:14AM -0700, Jakub Kicinski wrote:
> On Tue, 17 Aug 2021 15:24:54 +0300 Andy Shevchenko wrote:
> > Currently we are using BIT(), but GENMASK(). Make use of the latter one
> > as well (far less error-prone, far more concise).
> GENMASK is unsigned long:
Ouch, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-08-17 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 12:24 Andy Shevchenko
2021-08-17 13:48 ` Jakub Kicinski
2021-08-17 16:46 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRvnz01sPpHMnkqQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--subject='Re: [PATCH v2 net-next 1/1] ptp_ocp: use bits.h macros for all masks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).