LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	devicetree@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH 2/3] dt-bindings: msm: Add QTI download mode support binding
Date: Tue, 17 Aug 2021 16:28:39 -0500	[thread overview]
Message-ID: <YRwqBx4hNsbsPYY0@robh.at.kernel.org> (raw)
In-Reply-To: <217c22d40e0a9db713e2a55623408eca88166897.1628757036.git.saiprakash.ranjan@codeaurora.org>

On Thu, Aug 12, 2021 at 02:47:41PM +0530, Sai Prakash Ranjan wrote:
> Add device tree binding for QTI download mode cookies
> region found in IMEM.
> 
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
>  .../bindings/arm/msm/qcom,dload-mode.yaml     | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dload-mode.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dload-mode.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dload-mode.yaml
> new file mode 100644
> index 000000000000..90b9b6a9b75e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dload-mode.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/msm/qcom,dload-mode.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Download Mode binding
> +
> +maintainers:
> +  - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> +
> +description:
> +  Qualcomm download mode cookies memory region in IMEM is used by SDI
> +  (System Debug Image) firmware to determine whether to enter download
> +  mode or not to collect ramdump for post mortem debug.
> +
> +properties:
> +  compatible:
> +    const: qcom,dload-mode
> +
> +  reg:
> +    maxItems: 1
> +
> +  qcom,sdi-disable-regs:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description:
> +      Phandle reference to a syscon representing TCSR followed by the
> +      offset and length for SDI disable register.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    imem@146aa000 {
> +      compatible = "simple-mfd";

If this is just internal RAM, then we already have a binding for it and 
'simple-mfd' is not it.

> +      reg = <0x146aa000 0x2000>;
> +
> +      #address-cells = <1>;
> +      #size-cells = <1>;
> +
> +      ranges = <0 0x146aa000 0x2000>;
> +
> +      dload-mode@1c00 {
> +        compatible = "qcom,dload-mode";
> +        reg = <0x1c00 0x1000>;

0x1c00 + 0x1000 > 0x2000


> +        qcom,sdi-disable-regs = <&tcsr_regs 0x3a000 0x4>;
> +      };
> +    };
> +...
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
> 
> 

  reply	other threads:[~2021-08-17 21:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  9:17 [PATCH 0/3] soc: qcom: Add download mode support for QTI platforms Sai Prakash Ranjan
2021-08-12  9:17 ` [PATCH 1/3] soc: qcom: Add download mode support Sai Prakash Ranjan
2021-08-12  9:17 ` [PATCH 2/3] dt-bindings: msm: Add QTI download mode support binding Sai Prakash Ranjan
2021-08-17 21:28   ` Rob Herring [this message]
2021-08-18  3:36     ` Sai Prakash Ranjan
2021-08-12  9:17 ` [PATCH 3/3] arm64: dts: qcom: sc7180: Add IMEM, pil info and download mode region Sai Prakash Ranjan
2021-09-27 22:56   ` (subset) " Bjorn Andersson
2021-08-13  0:16 ` [PATCH 0/3] soc: qcom: Add download mode support for QTI platforms Stephen Boyd
2021-08-13  4:31   ` Trilok Soni
2021-08-16 10:38   ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRwqBx4hNsbsPYY0@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH 2/3] dt-bindings: msm: Add QTI download mode support binding' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).