LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/3] Add support for runtime features
@ 2021-08-17 13:05 Ronak Jain
  2021-08-17 13:05 ` [PATCH 1/3] firmware: xilinx: " Ronak Jain
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Ronak Jain @ 2021-08-17 13:05 UTC (permalink / raw)
  To: michal.simek, linux-kernel
  Cc: gregkh, rajan.vaja, corbet, linux-arm-kernel, arnd,
	lakshmi.sai.krishna.potthuri, Ronak Jain

Adds support for runtime feature configuration by using the IOCTL
 calls. The user can enable or disable as well as can configure the
 runtime features. The support is added for the over temperature and
 external watchdog. The user can configure the over temperature limit
 and external watchdog timer interval at runtime by using PM_IOCTL
 calls.

Also, added support for sysfs interface for runtime feature
configuration for the over temperature and external watchdog features.

Ronak Jain (3):
  firmware: xilinx: Add support for runtime features
  firmware: zynqmp: Add sysfs entry for runtime features
  firmware: xilinx: Add sysfs support for feature config

 .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 ++++++++++++++++
 drivers/firmware/xilinx/zynqmp.c              | 98 +++++++++++++++++++
 include/linux/firmware/xlnx-zynqmp.h          | 25 +++++
 3 files changed, 207 insertions(+)

--
2.32.0.93.g670b81a

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] firmware: xilinx: Add support for runtime features
  2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
@ 2021-08-17 13:05 ` Ronak Jain
  2021-08-17 13:05 ` [PATCH 2/3] firmware: zynqmp: Add sysfs entry " Ronak Jain
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Ronak Jain @ 2021-08-17 13:05 UTC (permalink / raw)
  To: michal.simek, linux-kernel
  Cc: gregkh, rajan.vaja, corbet, linux-arm-kernel, arnd,
	lakshmi.sai.krishna.potthuri, Ronak Jain

Add support for runtime features by using an IOCTL call. The features
 can be enabled or disabled on the firmware as well as the features
 can configure at runtime by querying IOCTL_SET_FEATURE_CONFIG id.
 Similarly, the user can get the configured values of features by
 querying IOCTL_GET_FEATURE_CONFIG id. Here, we have added support for
 the over temperature and external watchdog features only.

Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
---
 drivers/firmware/xilinx/zynqmp.c     | 27 +++++++++++++++++++++++++++
 include/linux/firmware/xlnx-zynqmp.h | 25 +++++++++++++++++++++++++
 2 files changed, 52 insertions(+)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index 15b138326ecc..e2b0a8fb6f44 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -1049,6 +1049,33 @@ int zynqmp_pm_system_shutdown(const u32 type, const u32 subtype)
                                   0, 0, NULL);
 }

+/**
+ * zynqmp_pm_set_feature_config - PM call to request IOCTL for feature config
+ * @id:         The config ID of the feature to be configured
+ * @value:      The config value of the feature to be configured
+ *
+ * Return:      Returns 0 on success or error value on failure.
+ */
+int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value)
+{
+       return zynqmp_pm_invoke_fn(PM_IOCTL, 0, IOCTL_SET_FEATURE_CONFIG,
+                                  id, value, NULL);
+}
+
+/**
+ * zynqmp_pm_get_feature_config - PM call to get value of configured feature
+ * @id:         The config id of the feature to be queried
+ * @payload:    Returned value array
+ *
+ * Return:      Returns 0 on success or error value on failure.
+ */
+int zynqmp_pm_get_feature_config(enum pm_feature_config_id id,
+                                u32 *payload)
+{
+       return zynqmp_pm_invoke_fn(PM_IOCTL, 0, IOCTL_GET_FEATURE_CONFIG,
+                                  id, 0, payload);
+}
+
 /**
  * struct zynqmp_pm_shutdown_scope - Struct for shutdown scope
  * @subtype:   Shutdown subtype
diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
index 9d1a5c175065..06d82e334d2b 100644
--- a/include/linux/firmware/xlnx-zynqmp.h
+++ b/include/linux/firmware/xlnx-zynqmp.h
@@ -119,6 +119,9 @@ enum pm_ioctl_id {
        IOCTL_READ_PGGS = 15,
        /* Set healthy bit value */
        IOCTL_SET_BOOT_HEALTH_STATUS = 17,
+       /* Runtime feature configuration */
+       IOCTL_SET_FEATURE_CONFIG = 26,
+       IOCTL_GET_FEATURE_CONFIG = 27,
 };

 enum pm_query_id {
@@ -347,6 +350,14 @@ enum zynqmp_pm_shutdown_subtype {
        ZYNQMP_PM_SHUTDOWN_SUBTYPE_SYSTEM = 2,
 };

+enum pm_feature_config_id {
+       PM_FEATURE_INVALID = 0,
+       PM_FEATURE_OVERTEMP_STATUS = 1,
+       PM_FEATURE_OVERTEMP_VALUE = 2,
+       PM_FEATURE_EXTWDT_STATUS = 3,
+       PM_FEATURE_EXTWDT_VALUE = 4,
+};
+
 /**
  * struct zynqmp_pm_query_data - PM query data
  * @qid:       query ID
@@ -411,6 +422,8 @@ int zynqmp_pm_pinctrl_get_config(const u32 pin, const u32 param,
                                 u32 *value);
 int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param,
                                 u32 value);
+int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value);
+int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, u32 *payload);
 #else
 static inline int zynqmp_pm_get_api_version(u32 *version)
 {
@@ -622,6 +635,18 @@ static inline int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param,
 {
        return -ENODEV;
 }
+
+static inline int zynqmp_pm_set_feature_config(enum pm_feature_config_id id,
+                                              u32 value)
+{
+       return -ENODEV;
+}
+
+static inline int zynqmp_pm_get_feature_config(enum pm_feature_config_id id,
+                                              u32 *payload)
+{
+       return -ENODEV;
+}
 #endif

 #endif /* __FIRMWARE_ZYNQMP_H__ */
--
2.32.0.93.g670b81a

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/3] firmware: zynqmp: Add sysfs entry for runtime features
  2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
  2021-08-17 13:05 ` [PATCH 1/3] firmware: xilinx: " Ronak Jain
@ 2021-08-17 13:05 ` Ronak Jain
  2021-08-17 13:05 ` [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config Ronak Jain
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Ronak Jain @ 2021-08-17 13:05 UTC (permalink / raw)
  To: michal.simek, linux-kernel
  Cc: gregkh, rajan.vaja, corbet, linux-arm-kernel, arnd,
	lakshmi.sai.krishna.potthuri, Ronak Jain

Create sysfs entry for runtime feature configuration. Here the support
 is added for an over temperature and external watchdog feature.

The below listed path is used for runtime features configuration:
/sys/devices/platform/firmware\:zynqmp-firmware/*

Here there are two files to configure features at runtime.
1. feature_config_id
2. feature_config_value

In order to configure an over temperature or external watchdog
 features, first the user need to select the valid config id and then
 the user can configure the value for selected feature config id.

Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
---
 .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 +++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
index f5724bb5b462..2fde354715a5 100644
--- a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
+++ b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
@@ -113,3 +113,87 @@ Description:
                    # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/health_status

 Users:         Xilinx
+
+What:          /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_*
+Date:          Aug 2021
+KernelVersion: 5.14
+Contact:       "Ronak Jain" <ronak.jain@xilinx.com>
+Description:
+               This sysfs interface allows to configure features at runtime.
+               The user can enable or disable features running at firmware.
+               Also, the user can configure the parameters of the features
+               at runtime. The supported features are over temperature and
+               external watchdog. Here, the external watchdog is completely
+               different than the /dev/watchdog as the external watchdog is
+               running on the firmware and it is used to monitor the health
+               of firmware not APU(Linux). Also, the external watchdog is
+               interfaced outside of the zynqmp soc.
+
+               By default the features are disabled in the firmware. The user
+               can enable features by querying appropriate config id of the
+               features.
+
+               The default limit for the over temperature is 90 Degree Celsius.
+               The default timer interval for the external watchdog is 570ms.
+
+               The supported config ids are for the feature configuration is,
+               1. PM_FEATURE_OVERTEMP_STATUS = 1, the user can enable or
+               disable the over temperature feature.
+               2. PM_FEATURE_OVERTEMP_VALUE = 2, the user can configure the
+               over temperature limit in Degree Celsius.
+               3. PM_FEATURE_EXTWDT_STATUS = 3, the user can enable or disable
+               the external watchdog feature.
+               4. PM_FEATURE_EXTWDT_VALUE = 4, the user can configure the
+               external watchdog feature.
+
+               Usage:
+
+               Enable over temperature feature
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the over temperature feature is enabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 1.
+
+               Disable over temperature feature
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the over temperature feature is disabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 0.
+
+               Configure over temperature limit to 50 Degree Celsius
+               # echo 2 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 50 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the over temperature limit is configured or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 50.
+
+               Enable external watchdog feature
+               # echo 3 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the external watchdog feature is enabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 1.
+
+               Disable external watchdog feature
+               # echo 3 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the external watchdog feature is disabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 0.
+
+               Configure external watchdog timer interval to 500ms
+               # echo 4 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 500 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the external watchdog timer interval is configured or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 500.
+
+Users:         Xilinx
--
2.32.0.93.g670b81a

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config
  2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
  2021-08-17 13:05 ` [PATCH 1/3] firmware: xilinx: " Ronak Jain
  2021-08-17 13:05 ` [PATCH 2/3] firmware: zynqmp: Add sysfs entry " Ronak Jain
@ 2021-08-17 13:05 ` Ronak Jain
  2021-08-18  6:43 ` [PATCH 0/3] Add support for runtime features Michael Tretter
  2021-08-18  8:08 ` Greg KH
  4 siblings, 0 replies; 7+ messages in thread
From: Ronak Jain @ 2021-08-17 13:05 UTC (permalink / raw)
  To: michal.simek, linux-kernel
  Cc: gregkh, rajan.vaja, corbet, linux-arm-kernel, arnd,
	lakshmi.sai.krishna.potthuri, Ronak Jain

This patch adds support for sysfs interface for runtime features
 configuration. The user can configure the features at runtime. First
 the user need to select the config id of the supported features and
 then the user can configure the parameters of the feature based on
 the config id. So far the support is added for the over temperature
 and external watchdog features.

Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
---
 drivers/firmware/xilinx/zynqmp.c | 71 ++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index e2b0a8fb6f44..4c5010899837 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -1344,6 +1344,75 @@ static DEVICE_ATTR_RW(pggs1);
 static DEVICE_ATTR_RW(pggs2);
 static DEVICE_ATTR_RW(pggs3);

+static atomic_t feature_conf_id;
+
+static ssize_t feature_config_id_show(struct device *device,
+                                     struct device_attribute *attr,
+                                     char *buf)
+{
+       return sysfs_emit(buf, "%d\n", atomic_read(&feature_conf_id));
+}
+
+static ssize_t feature_config_id_store(struct device *device,
+                                      struct device_attribute *attr,
+                                      const char *buf, size_t count)
+{
+       u32 config_id;
+       int ret;
+
+       if (!buf)
+               return -EINVAL;
+
+       ret = kstrtou32(buf, 10, &config_id);
+       if (ret)
+               return ret;
+
+       atomic_set(&feature_conf_id, config_id);
+
+       return count;
+}
+
+static DEVICE_ATTR_RW(feature_config_id);
+
+static ssize_t feature_config_value_show(struct device *device,
+                                        struct device_attribute *attr,
+                                        char *buf)
+{
+       int ret;
+       u32 ret_payload[PAYLOAD_ARG_CNT];
+
+       ret = zynqmp_pm_get_feature_config(atomic_read(&feature_conf_id),
+                                          ret_payload);
+       if (ret)
+               return ret;
+
+       return sysfs_emit(buf, "%d\n", ret_payload[1]);
+}
+
+static ssize_t feature_config_value_store(struct device *device,
+                                         struct device_attribute *attr,
+                                         const char *buf, size_t count)
+{
+       u32 value;
+       int ret;
+
+       if (!buf)
+               return -EINVAL;
+
+       ret = kstrtou32(buf, 10, &value);
+       if (ret)
+               return ret;
+
+       ret = zynqmp_pm_set_feature_config(atomic_read(&feature_conf_id),
+                                          value);
+       if (ret)
+               return ret;
+
+       return count;
+}
+
+static DEVICE_ATTR_RW(feature_config_value);
+
 static struct attribute *zynqmp_firmware_attrs[] = {
        &dev_attr_ggs0.attr,
        &dev_attr_ggs1.attr,
@@ -1355,6 +1424,8 @@ static struct attribute *zynqmp_firmware_attrs[] = {
        &dev_attr_pggs3.attr,
        &dev_attr_shutdown_scope.attr,
        &dev_attr_health_status.attr,
+       &dev_attr_feature_config_id.attr,
+       &dev_attr_feature_config_value.attr,
        NULL,
 };

--
2.32.0.93.g670b81a

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Add support for runtime features
  2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
                   ` (2 preceding siblings ...)
  2021-08-17 13:05 ` [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config Ronak Jain
@ 2021-08-18  6:43 ` Michael Tretter
  2021-08-18  8:08 ` Greg KH
  4 siblings, 0 replies; 7+ messages in thread
From: Michael Tretter @ 2021-08-18  6:43 UTC (permalink / raw)
  To: Ronak Jain
  Cc: michal.simek, linux-kernel, gregkh, rajan.vaja, corbet,
	linux-arm-kernel, arnd, lakshmi.sai.krishna.potthuri, kernel

Hi Ronak,

On Tue, 17 Aug 2021 06:05:50 -0700, Ronak Jain wrote:
> Adds support for runtime feature configuration by using the IOCTL
>  calls. The user can enable or disable as well as can configure the
>  runtime features. The support is added for the over temperature and
>  external watchdog. The user can configure the over temperature limit
>  and external watchdog timer interval at runtime by using PM_IOCTL
>  calls.
> 
> Also, added support for sysfs interface for runtime feature
> configuration for the over temperature and external watchdog features.

Can we have proper kernel drivers instead of the sysfs interface?

Michael

> 
> Ronak Jain (3):
>   firmware: xilinx: Add support for runtime features
>   firmware: zynqmp: Add sysfs entry for runtime features
>   firmware: xilinx: Add sysfs support for feature config
> 
>  .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 ++++++++++++++++
>  drivers/firmware/xilinx/zynqmp.c              | 98 +++++++++++++++++++
>  include/linux/firmware/xlnx-zynqmp.h          | 25 +++++
>  3 files changed, 207 insertions(+)
> 
> --
> 2.32.0.93.g670b81a
> 
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Add support for runtime features
  2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
                   ` (3 preceding siblings ...)
  2021-08-18  6:43 ` [PATCH 0/3] Add support for runtime features Michael Tretter
@ 2021-08-18  8:08 ` Greg KH
  2021-08-19  3:57   ` Ronak Jain
  4 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2021-08-18  8:08 UTC (permalink / raw)
  To: Ronak Jain
  Cc: michal.simek, linux-kernel, rajan.vaja, corbet, linux-arm-kernel,
	arnd, lakshmi.sai.krishna.potthuri

On Tue, Aug 17, 2021 at 06:05:50AM -0700, Ronak Jain wrote:
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

This footer means that this has to be ignored and can not be used for
kernel development at all.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH 0/3] Add support for runtime features
  2021-08-18  8:08 ` Greg KH
@ 2021-08-19  3:57   ` Ronak Jain
  0 siblings, 0 replies; 7+ messages in thread
From: Ronak Jain @ 2021-08-19  3:57 UTC (permalink / raw)
  To: Greg KH
  Cc: Michal Simek, linux-kernel, Rajan Vaja, corbet, linux-arm-kernel,
	arnd, Sai Krishna Potthuri

Hi Greg KH,

Thanks for reviewing.

I will fix footer and submit new version.

Thanks,
Ronak

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, August 18, 2021 1:38 PM
> To: Ronak Jain <ronakj@xilinx.com>
> Cc: Michal Simek <michals@xilinx.com>; linux-kernel@vger.kernel.org; Rajan
> Vaja <RAJANV@xilinx.com>; corbet@lwn.net; linux-arm-
> kernel@lists.infradead.org; arnd@arndb.de; Sai Krishna Potthuri
> <lakshmis@xilinx.com>
> Subject: Re: [PATCH 0/3] Add support for runtime features
> 
> On Tue, Aug 17, 2021 at 06:05:50AM -0700, Ronak Jain wrote:
> > This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any attachments.
> Delete this email message and any attachments immediately.
> 
> This footer means that this has to be ignored and can not be used for kernel
> development at all.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-08-19  3:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
2021-08-17 13:05 ` [PATCH 1/3] firmware: xilinx: " Ronak Jain
2021-08-17 13:05 ` [PATCH 2/3] firmware: zynqmp: Add sysfs entry " Ronak Jain
2021-08-17 13:05 ` [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config Ronak Jain
2021-08-18  6:43 ` [PATCH 0/3] Add support for runtime features Michael Tretter
2021-08-18  8:08 ` Greg KH
2021-08-19  3:57   ` Ronak Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).