LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: straube.linux@gmail.com, dan.carpenter@oracle.com,
	yangyingliang@huawei.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove unused including <linux/version.h>
Date: Wed, 18 Aug 2021 07:41:43 +0200	[thread overview]
Message-ID: <YRydlwA9kNvI1rvp@kroah.com> (raw)
In-Reply-To: <20210818022321.2395-1-caihuoqing@baidu.com>

On Wed, Aug 18, 2021 at 10:23:21AM +0800, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it
> based on staging-next

No need for this line in here, describing what tree this was made
against.  Please, if you need to say stuff like this, put it below the
--- line.

Can you please fix up and resend?

thanks,

greg k-h

      reply	other threads:[~2021-08-18  5:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18  2:23 Cai Huoqing
2021-08-18  5:41 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRydlwA9kNvI1rvp@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=caihuoqing@baidu.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    --cc=yangyingliang@huawei.com \
    --subject='Re: [PATCH] staging: r8188eu: Remove unused including <linux/version.h>' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).