LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] flow_offload: action should not be NULL when it is referenced
@ 2021-06-26 11:56 13145886936
  2021-06-28 21:30 ` patchwork-bot+netdevbpf
  2021-08-18 11:58 ` Ido Schimmel
  0 siblings, 2 replies; 5+ messages in thread
From: 13145886936 @ 2021-06-26 11:56 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, gushengxian, gushengxian

From: gushengxian <gushengxian@yulong.com>

"action" should not be NULL when it is referenced.

Signed-off-by: gushengxian <13145886936@163.com>
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
 include/net/flow_offload.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index dc5c1e69cd9f..69c9eabf8325 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -319,12 +319,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
 	if (flow_offload_has_one_action(action))
 		return true;
 
-	flow_action_for_each(i, action_entry, action) {
-		if (i && action_entry->hw_stats != last_hw_stats) {
-			NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
-			return false;
+	if (action) {
+		flow_action_for_each(i, action_entry, action) {
+			if (i && action_entry->hw_stats != last_hw_stats) {
+				NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
+				return false;
+			}
+			last_hw_stats = action_entry->hw_stats;
 		}
-		last_hw_stats = action_entry->hw_stats;
 	}
 	return true;
 }
-- 
2.25.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-18 13:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-26 11:56 [PATCH] flow_offload: action should not be NULL when it is referenced 13145886936
2021-06-28 21:30 ` patchwork-bot+netdevbpf
2021-08-18 11:58 ` Ido Schimmel
2021-08-18 12:36   ` Jamal Hadi Salim
2021-08-18 13:39     ` Ido Schimmel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).