LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: "Maxime Ripard" <mripard@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>, "Clément Bœsch" <u@pkh.me>,
	"Willy Liu" <willy.liu@realtek.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
Date: Mon, 30 Aug 2021 23:50:42 +0200	[thread overview]
Message-ID: <YS1SsqDgGFOvyIT0@lunn.ch> (raw)
In-Reply-To: <116454729.UZi3dMzWh7@jernej-laptop>

On Mon, Aug 30, 2021 at 10:49:37PM +0200, Jernej Škrabec wrote:
> Hi!
> 
> Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch napisal(a):
> > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") network is broken on the NanoPi Neo 2.
> > 
> > This patch changes the phy-mode to use internal delays both for RX and
> > TX as has been done for other boards affected by the same commit.
> > 
> > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> 
> This commit fixes DT issue, so "fixes" tag should be:
> Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> 
> Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board DT.  

Hi Jernej

I would say, it is debatable. The board broke when the driver started
acting on the value, which is commit bbc4d71d6354. It could be argued
it was always technically broken, since it has the wrong value, but
practically, it was not broken. One of the rules for stable is:

 - It must fix a real bug that bothers people (not a, "This could be a
   problem..." type thing).

So i would argue, anything before bbc4d71d6354 does not fulfil stable
requirements, since it does not bother anybody.

      Andrew

  parent reply	other threads:[~2021-08-30 21:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 15:16 Clément Bœsch
2021-08-30 20:49 ` Jernej Škrabec
2021-08-30 21:25   ` Clément Bœsch
2021-08-31 20:17     ` Jernej Škrabec
2021-08-30 21:50   ` Andrew Lunn [this message]
2021-08-31 19:53     ` Jernej Škrabec
2021-08-31 20:53       ` Andrew Lunn
2021-09-01 15:31         ` Jernej Škrabec
2021-09-03  9:21           ` Maxime Ripard
2021-09-05  0:20   ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
2021-09-05  0:42     ` Andrew Lunn
2021-09-06  8:03     ` Maxime Ripard
2021-08-30 21:52 ` [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YS1SsqDgGFOvyIT0@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=u@pkh.me \
    --cc=wens@csie.org \
    --cc=willy.liu@realtek.com \
    --subject='Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).