LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joel Becker <jlbec@evilplan.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sishuai Gong <sishuai@purdue.edu>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/4] configfs: fix a race in configfs_lookup()
Date: Tue, 31 Aug 2021 05:53:36 +0000	[thread overview]
Message-ID: <YS3D4PH/OdoE+WQA@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20210825064906.1694233-5-hch@lst.de>

Acked-by: Joel Becker <jlbec@evilplan.org>

On Wed, Aug 25, 2021 at 08:49:06AM +0200, Christoph Hellwig wrote:
> From: Sishuai Gong <sishuai@purdue.edu>
> 
> When configfs_lookup() is executing list_for_each_entry(),
> it is possible that configfs_dir_lseek() is calling list_del().
> Some unfortunate interleavings of them can cause a kernel NULL
> pointer dereference error
> 
> Thread 1                  Thread 2
> //configfs_dir_lseek()    //configfs_lookup()
> list_del(&cursor->s_sibling);
>                          list_for_each_entry(sd, ...)
> 
> Fix this by grabbing configfs_dirent_lock in configfs_lookup()
> while iterating ->s_children.
> 
> Signed-off-by: Sishuai Gong <sishuai@purdue.edu>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/configfs/dir.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
> index fc20bd8a6337..1466b5d01cbb 100644
> --- a/fs/configfs/dir.c
> +++ b/fs/configfs/dir.c
> @@ -439,13 +439,13 @@ static struct dentry * configfs_lookup(struct inode *dir,
>  	if (!configfs_dirent_is_ready(parent_sd))
>  		return ERR_PTR(-ENOENT);
>  
> +	spin_lock(&configfs_dirent_lock);
>  	list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
>  		if ((sd->s_type & CONFIGFS_NOT_PINNED) &&
>  		    !strcmp(configfs_get_name(sd), dentry->d_name.name)) {
>  			struct configfs_attribute *attr = sd->s_element;
>  			umode_t mode = (attr->ca_mode & S_IALLUGO) | S_IFREG;
>  
> -			spin_lock(&configfs_dirent_lock);
>  			dentry->d_fsdata = configfs_get(sd);
>  			sd->s_dentry = dentry;
>  			spin_unlock(&configfs_dirent_lock);
> @@ -462,10 +462,11 @@ static struct dentry * configfs_lookup(struct inode *dir,
>  				inode->i_size = PAGE_SIZE;
>  				inode->i_fop = &configfs_file_operations;
>  			}
> -			break;
> +			goto done;
>  		}
>  	}
> -
> +	spin_unlock(&configfs_dirent_lock);
> +done:
>  	d_add(dentry, inode);
>  	return NULL;
>  }
> -- 
> 2.30.2
> 

-- 

      reply	other threads:[~2021-08-31  5:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  6:49 configfs lookup race fix Christoph Hellwig
2021-08-25  6:49 ` [PATCH 1/4] configfs: return -ENAMETOOLONG earlier in configfs_lookup Christoph Hellwig
2021-08-31  5:50   ` Joel Becker
2021-08-31  5:52   ` Joel Becker
2021-08-25  6:49 ` [PATCH 2/4] configfs: simplify the configfs_dirent_is_ready Christoph Hellwig
2021-08-31  5:51   ` Joel Becker
2021-08-25  6:49 ` [PATCH 3/4] configfs: fold configfs_attach_attr into configfs_lookup Christoph Hellwig
2021-08-31  5:52   ` Joel Becker
2021-08-25  6:49 ` [PATCH 4/4] configfs: fix a race in configfs_lookup() Christoph Hellwig
2021-08-31  5:53   ` Joel Becker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YS3D4PH/OdoE+WQA@zeniv-ca.linux.org.uk \
    --to=jlbec@evilplan.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sishuai@purdue.edu \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH 4/4] configfs: fix a race in configfs_lookup()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).