LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Joel Stanley <joel@jms.id.au>
Cc: openrisc@lists.librecores.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] openrisc/litex: Add liteeth support
Date: Tue, 31 Aug 2021 22:38:22 +0900	[thread overview]
Message-ID: <YS4wzi1o0zwEjRuK@antec> (raw)
In-Reply-To: <CACPK8XdzpSpz_iswn7ojE1TbXpYFqG2orALSvJP7piq=UC0xDg@mail.gmail.com>

On Mon, Aug 30, 2021 at 01:41:26AM +0000, Joel Stanley wrote:
> On Mon, 30 Aug 2021 at 00:17, Stafford Horne <shorne@gmail.com> wrote:
> >
> > On Thu, Aug 26, 2021 at 10:59:43PM +0930, Joel Stanley wrote:
> > > Hello Stafford,
> > >
> > > Here are some changes so that the openrisc kernel can boot with ethernet
> > > support with the in-tree device tree.
> > >
> > > I have also updated the address of the serial device to match recent
> > > litex. I realise this may keep changing, but it does make it easier to
> > > test upstream kernels if the basics work.
> > >
> > > Joel Stanley (3):
> > >   openrisc/litex: Update uart address
> > >   openrisc/litex: Add ethernet device
> > >   openrisc/litex: Update defconfig
> > >
> > >  arch/openrisc/boot/dts/or1klitex.dts      | 13 ++++++++++--
> > >  arch/openrisc/configs/or1klitex_defconfig | 26 ++++++++++++++---------
> > >  2 files changed, 27 insertions(+), 12 deletions(-)
> >
> > Hi,
> >
> > These all look fine to me.  Note, I have just using the autogenerated .dts file
> > created by the litex build, so I don't usually use this one other than for some
> > basic testing.  I know auto generated one has it's quirks but it does work.
> >
> > It's good to have these here though.
> 
> Agreed.
> 
> The auto generated ones need a lot of work to be relevant outside of
> the vexriscv CPU (I tried to build for rocket, a different riscv, and
> the script blew up...).
> 
> In the future it would be good to have this one support the drivers
> that are merged upstream.
> 
> >
> > I will queue these after the ehternet driver is queued.  Are you planning me to
> > queue the ethernet driver?  Or will someone else be taking that in?
> 
> I should have mentioned that the driver and bindings were merged
> through the network tree last week. You can see them in Friday's
> linux-next.

Alright, in that case I am adding them now.

-Stafford


      reply	other threads:[~2021-08-31 13:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 13:29 Joel Stanley
2021-08-26 13:29 ` [PATCH 1/3] openrisc/litex: Update uart address Joel Stanley
2021-08-26 13:29 ` [PATCH 2/3] openrisc/litex: Add ethernet device Joel Stanley
2021-08-26 13:29 ` [PATCH 3/3] openrisc/litex: Update defconfig Joel Stanley
2021-08-30  0:17 ` [PATCH 0/3] openrisc/litex: Add liteeth support Stafford Horne
2021-08-30  1:41   ` Joel Stanley
2021-08-31 13:38     ` Stafford Horne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YS4wzi1o0zwEjRuK@antec \
    --to=shorne@gmail.com \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openrisc@lists.librecores.org \
    --subject='Re: [PATCH 0/3] openrisc/litex: Add liteeth support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).