From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C194EC432BE for ; Tue, 31 Aug 2021 13:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D32B60F92 for ; Tue, 31 Aug 2021 13:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237805AbhHaNjV (ORCPT ); Tue, 31 Aug 2021 09:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236590AbhHaNjU (ORCPT ); Tue, 31 Aug 2021 09:39:20 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2947EC061575 for ; Tue, 31 Aug 2021 06:38:25 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id y17so1612819pfl.13 for ; Tue, 31 Aug 2021 06:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WzysMINDWCSbmHUc9UvnAx/N2L4Si/qdlxqcZ4CNB3s=; b=m+Qt4PzmYB1nmb0a2Wh2dxp5PBGb3Jj43cs0twsUIXl5ay0x8k/H6lseNGCNXH+z+S UiJWXQUD4WrH6eY/LJbBVKFewGkj+P5Y4nMD2pnVDaiPsX3QvmXAvDF458Om4IhgOQoG uEs6YSkHWc0rBH+SsZHMCLnbqerEebD7lMf74BycmhujV9/iXyNFNUHqTaUDhV5qiDOY zHaxpO6OSTNbSUa3YxeW98+J7E0SyvaJ3d0sXrOvQX0VT/Kf8O7RolyiadYtZH5folWZ Au3iBRifP/L46Da4PGkpNmfd/encLK4v5JvmjaHAdZZ7C/boACzvxeAW8V8Ju2FSIJAm G3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WzysMINDWCSbmHUc9UvnAx/N2L4Si/qdlxqcZ4CNB3s=; b=SGyPg/3JoKz7ct7Z8s2RK30ctaz+DfUi0mFhjBWJsRe9j4AstkrLHacE5VtC9reB02 pCl0ubJIrwp8hkteUHtcq6iiAT9s/kX8ejbY6aFck04hyzGx8+9JsAyOmLwBconddWc1 DcgN4gB2dEra5NcvRzlfyVXaAJnUFEmAjy80qegBNwbFipEugyzTek/2/TGAFYZ9ggdB 5NYerlsZgxzhdx4hQGXZWVgp6EtAFOrDjypnKzafUbEA2l1b70JJRhM128AW0Of21WW0 YZzGnfK0iBZTsM10kiStWMYzJXeLBo7f4v1y5tGHqPgMNK0R1Mk36NuULjq3SG0DL3+W rMnA== X-Gm-Message-State: AOAM533Jfd+8KbqjW142EAO6Suf2ncsVP0ZRXX8oGBXEXCIVqHHkXjnL 0dSDk46Hh4cADhpDAMLLMumeNc7dIOc= X-Google-Smtp-Source: ABdhPJyT8UW/wkzA5qBJI5yn9jYvdYygleKLr9uaVhsUiJag/yc7Fa/7urLfv1YSedfhKyZZzl3pGQ== X-Received: by 2002:a63:d10b:: with SMTP id k11mr10730282pgg.26.1630417104664; Tue, 31 Aug 2021 06:38:24 -0700 (PDT) Received: from localhost (g163.222-224-165.ppp.wakwak.ne.jp. [222.224.165.163]) by smtp.gmail.com with ESMTPSA id a21sm3185180pjo.14.2021.08.31.06.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:38:23 -0700 (PDT) Date: Tue, 31 Aug 2021 22:38:22 +0900 From: Stafford Horne To: Joel Stanley Cc: openrisc@lists.librecores.org, Linux Kernel Mailing List Subject: Re: [PATCH 0/3] openrisc/litex: Add liteeth support Message-ID: References: <20210826132946.3324593-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 01:41:26AM +0000, Joel Stanley wrote: > On Mon, 30 Aug 2021 at 00:17, Stafford Horne wrote: > > > > On Thu, Aug 26, 2021 at 10:59:43PM +0930, Joel Stanley wrote: > > > Hello Stafford, > > > > > > Here are some changes so that the openrisc kernel can boot with ethernet > > > support with the in-tree device tree. > > > > > > I have also updated the address of the serial device to match recent > > > litex. I realise this may keep changing, but it does make it easier to > > > test upstream kernels if the basics work. > > > > > > Joel Stanley (3): > > > openrisc/litex: Update uart address > > > openrisc/litex: Add ethernet device > > > openrisc/litex: Update defconfig > > > > > > arch/openrisc/boot/dts/or1klitex.dts | 13 ++++++++++-- > > > arch/openrisc/configs/or1klitex_defconfig | 26 ++++++++++++++--------- > > > 2 files changed, 27 insertions(+), 12 deletions(-) > > > > Hi, > > > > These all look fine to me. Note, I have just using the autogenerated .dts file > > created by the litex build, so I don't usually use this one other than for some > > basic testing. I know auto generated one has it's quirks but it does work. > > > > It's good to have these here though. > > Agreed. > > The auto generated ones need a lot of work to be relevant outside of > the vexriscv CPU (I tried to build for rocket, a different riscv, and > the script blew up...). > > In the future it would be good to have this one support the drivers > that are merged upstream. > > > > > I will queue these after the ehternet driver is queued. Are you planning me to > > queue the ethernet driver? Or will someone else be taking that in? > > I should have mentioned that the driver and bindings were merged > through the network tree last week. You can see them in Friday's > linux-next. Alright, in that case I am adding them now. -Stafford