LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] perf tools: Add missing newline at the end of file
@ 2021-08-24  8:59 Nghia Le
  2021-08-24 14:37 ` Lukas Bulwahn
  0 siblings, 1 reply; 3+ messages in thread
From: Nghia Le @ 2021-08-24  8:59 UTC (permalink / raw)
  To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung
  Cc: Nghia Le, linux-kernel, linux-perf-users, lukas.bulwahn

Add missing newline at the end of file parse-sublevel-options.h.
Thus removing relevant warning reported by checkpatch.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 tools/perf/util/parse-sublevel-options.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
index 9b9efcc2aaad..578b18ef03bb 100644
--- a/tools/perf/util/parse-sublevel-options.h
+++ b/tools/perf/util/parse-sublevel-options.h
@@ -8,4 +8,4 @@ struct sublevel_option {
 
 int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
 
-#endif
\ No newline at end of file
+#endif
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Add missing newline at the end of file
  2021-08-24  8:59 [PATCH] perf tools: Add missing newline at the end of file Nghia Le
@ 2021-08-24 14:37 ` Lukas Bulwahn
  2021-08-24 18:03   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2021-08-24 14:37 UTC (permalink / raw)
  To: Nghia Le
  Cc: Peter Zijlstra, Ingo Molnar, acme, mark.rutland,
	alexander.shishkin, jolsa, Namhyung Kim,
	Linux Kernel Mailing List, linux-perf-users

On Tue, Aug 24, 2021 at 11:00 AM Nghia Le <nghialm78@gmail.com> wrote:
>
> Add missing newline at the end of file parse-sublevel-options.h.
> Thus removing relevant warning reported by checkpatch.
>
> Signed-off-by: Nghia Le <nghialm78@gmail.com>

Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

This addresses the only instance of a "no newline at the end of the
file" throughout the kernel tree.

This is part of a larger effort to identify all rules that checkpatch
warns about and that are never false positives (compared to the many
rules in checkpatch that are heuristics or are known to be ignored by
the current development community and hence, cause many false
positives). We could use such rules to be enforced in the submission
process.

Lukas
Lukas
> ---
>  tools/perf/util/parse-sublevel-options.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> index 9b9efcc2aaad..578b18ef03bb 100644
> --- a/tools/perf/util/parse-sublevel-options.h
> +++ b/tools/perf/util/parse-sublevel-options.h
> @@ -8,4 +8,4 @@ struct sublevel_option {
>
>  int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
>
> -#endif
> \ No newline at end of file
> +#endif
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Add missing newline at the end of file
  2021-08-24 14:37 ` Lukas Bulwahn
@ 2021-08-24 18:03   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-08-24 18:03 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Nghia Le, Peter Zijlstra, Ingo Molnar, mark.rutland,
	alexander.shishkin, jolsa, Namhyung Kim,
	Linux Kernel Mailing List, linux-perf-users

Em Tue, Aug 24, 2021 at 04:37:19PM +0200, Lukas Bulwahn escreveu:
> On Tue, Aug 24, 2021 at 11:00 AM Nghia Le <nghialm78@gmail.com> wrote:
> >
> > Add missing newline at the end of file parse-sublevel-options.h.
> > Thus removing relevant warning reported by checkpatch.
> >
> > Signed-off-by: Nghia Le <nghialm78@gmail.com>
> 
> Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>


Thanks, applied.

- Arnaldo

 
> This addresses the only instance of a "no newline at the end of the
> file" throughout the kernel tree.
> 
> This is part of a larger effort to identify all rules that checkpatch
> warns about and that are never false positives (compared to the many
> rules in checkpatch that are heuristics or are known to be ignored by
> the current development community and hence, cause many false
> positives). We could use such rules to be enforced in the submission
> process.
> 
> Lukas
> Lukas
> > ---
> >  tools/perf/util/parse-sublevel-options.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> > index 9b9efcc2aaad..578b18ef03bb 100644
> > --- a/tools/perf/util/parse-sublevel-options.h
> > +++ b/tools/perf/util/parse-sublevel-options.h
> > @@ -8,4 +8,4 @@ struct sublevel_option {
> >
> >  int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
> >
> > -#endif
> > \ No newline at end of file
> > +#endif
> > --
> > 2.25.1
> >

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-24 18:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24  8:59 [PATCH] perf tools: Add missing newline at the end of file Nghia Le
2021-08-24 14:37 ` Lukas Bulwahn
2021-08-24 18:03   ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).