LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: brookxu <brookxu.cn@gmail.com>,
	lizefan.x@bytedance.com, hannes@cmpxchg.org, vipinsh@google.com,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures
Date: Tue, 24 Aug 2021 09:08:49 -1000	[thread overview]
Message-ID: <YSVDwc/1sEmXdOK9@slm.duckdns.org> (raw)
In-Reply-To: <20210824164423.GA11859@blackbody.suse.cz>

Hello,

On Tue, Aug 24, 2021 at 06:44:23PM +0200, Michal Koutný wrote:
> However, the non-hierarchical failcnt interface looks like v1ism to me
> (I think new features should come with v2 first in mind).
> What about exposing this in misc.events file with max.$res_name entries? 

Ah yeah, good point. misc.events sounds like a good spot to put these.

> Or if the hierarchical reporting is unnecessary now, there can be just
> misc.events.local for starters.

I'd prefer to stick with hierarchical counting as the first step at least.

> (That reminds me the forgotten pids.events[.local] rework [1], oops.)
> 
> https://lore.kernel.org/lkml/20191128172612.10259-1-mkoutny@suse.com/#t

I think both counters are useful - the number of failures due to this type
of limit in this subhierarchy, and the number of failures caused by this
particular limit in this subhierarchy. It's a pretty subtle difference to
encapsulate in a counter name tho.

Thanks.

-- 
tejun

  reply	other threads:[~2021-08-24 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14  0:15 brookxu
2021-08-14  1:16 ` Vipin Sharma
2021-08-24 16:44 ` Michal Koutný
2021-08-24 19:08   ` Tejun Heo [this message]
2021-08-25  6:50     ` brookxu
2021-08-26  1:34     ` brookxu
2021-08-26 11:29       ` Michal Koutný
2021-09-08  5:29         ` brookxu
2021-09-09 15:01           ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSVDwc/1sEmXdOK9@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=brookxu.cn@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=vipinsh@google.com \
    --subject='Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).