From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A22AC432BE for ; Wed, 25 Aug 2021 21:31:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06BA2610C8 for ; Wed, 25 Aug 2021 21:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231745AbhHYVcd (ORCPT ); Wed, 25 Aug 2021 17:32:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:35152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhHYVcb (ORCPT ); Wed, 25 Aug 2021 17:32:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5593F610A1; Wed, 25 Aug 2021 21:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629927105; bh=GQpaLXOeTre1tnsmkfBCzjL/6oulqKgM/Nfy5gJGBlM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LeTFnAR42dMEaeLmLllAJtGnnuzmOTJ2zuduQj1EvtxFxgbK1UB8lG+6GyHEg6I+t cDe8Lssni0jvQce61VRK6rx2/ZjiKIQLgCCStezU1EXnHH4ON4miFWP4wni7blVQFC mRbQ/9f8/ECcFAFrPDCOMOPWF3HJHiJtslKIUGiu/9tL7afKYrOxmoPA385+pha4cG g1moZrSG/jIBFYHiwc9R/tcFozpBOiqeNT7Fcnl70vYRsFrU/5EMPXwe9pYkhvBJGM ENHEoI0x43sGo5BF7gLD4bij8B7W1lfmjpTwJh7QtHfhvqITuryuL0JfOOC4nc/TZi KYHc77utMzp3Q== Date: Wed, 25 Aug 2021 14:31:43 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: don't ignore writing pages on fsync during checkpoint=disable Message-ID: References: <20210823170151.1434772-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25, Chao Yu wrote: > On 2021/8/25 1:09, Jaegeuk Kim wrote: > > On 08/24, Chao Yu wrote: > > > On 2021/8/24 1:01, Jaegeuk Kim wrote: > > > > We must flush dirty pages when calling fsync() during checkpoint=disable. > > > > Returning zero makes inode being clear, which fails to flush them when > > > > enabling checkpoint back even by sync_inodes_sb(). > > > > > > Without this patch, file can be persisted via checkpoint=enable as well, my > > > testcase: > > > > > > - mount -t f2fs -o checkpoint=disable,checkpoint_nomerge /dev/pmem0 /mnt/f2fs/ > > > - cp file /mnt/f2fs/ > > > - xfs_io /mnt/f2fs/file -c "fdatasync" > > > - mount -o remount,checkpoint=enable /dev/pmem0 /mnt/f2fs/ > > > - umount /mnt/f2fs > > > - mount /dev/pmem0 /mnt/f2fs > > > - md5sum file /mnt/f2fs/file > > > chksum values are the same. > > > > > > Am I missing something? > > > > I'm trying to address one subtle issue where a file has only NEW_ADDR by the > > Oh, I doubt that we may failed to flush data of all inodes due to failures during > sync_inodes_sb(), additionally, how about adding retry logic for sync_inodes_sb() > if there is still any F2FS_DIRTY_DATA reference counts in f2fs_enable_checkpoint() > to mitigate this issue, e.g.: > > f2fs_enable_checkpoint() > > do { > sync_inode_sb(); > congestion_wait(); > cond_resched(); > } while (get_pages(sbi, F2FS_DIRTY_DATA) && retry_count--) > > if (get_pages(sbi, F2FS_DIRTY_DATA)) > f2fs_warm(""); Agreed. Sent v2. > > Thanks, > > > checkpoint=disable test. I don't think this hurts anything but can see > > some mitigation of the issue. > > > > > > > > Thanks,