LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryan Brattlof <hello@bryanbrattlof.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem()
Date: Fri, 27 Aug 2021 18:26:22 +0200	[thread overview]
Message-ID: <YSkSLrmhb4AcKlWu@kroah.com> (raw)
In-Reply-To: <39bc74b0303bb31cef0ac44b9ae2b2aa7abbe645.1630080164.git.hello@bryanbrattlof.com>

On Fri, Aug 27, 2021 at 04:13:15PM +0000, Bryan Brattlof wrote:
> The sdio_write_mem() function is unused in the driver. We can remove it.
> 
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
>  drivers/staging/rtl8723bs/include/rtw_io.h |  1 -
>  2 files changed, 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index a545832a468e..b784a390c8e1 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -356,16 +356,6 @@ static void sdio_read_mem(
>  	sdio_readN(intfhdl, addr, cnt, rmem);
>  }
> 
> -static void sdio_write_mem(
> -	struct intf_hdl *intfhdl,
> -	u32 addr,
> -	u32 cnt,
> -	u8 *wmem
> -)
> -{
> -	sdio_writeN(intfhdl, addr, cnt, wmem);
> -}
> -
>  /*
>   * Description:
>   *Read from RX FIFO
> @@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
>  	ops->_write16 = &sdio_write16;
>  	ops->_write32 = &sdio_write32;
>  	ops->_writeN = &sdio_writeN;
> -	ops->_write_mem = &sdio_write_mem;
>  	ops->_write_port = &sdio_write_port;
>  }
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
> index e98083a07a66..87f36b7e880f 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_io.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_io.h
> @@ -91,7 +91,6 @@ struct _io_ops {
>  		int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
> 
>  		void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> -		void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> 
>  		void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);
> 
> --
> 2.30.2
> 
> 
> 

THis changed from the previous version in ways you did not document
anywhere.  Please fix up in your v4 notes.

  reply	other threads:[~2021-08-27 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 16:12 [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
2021-08-27 16:13 ` [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
2021-08-27 16:26   ` Greg Kroah-Hartman [this message]
2021-08-27 16:22 ` [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
2021-08-27 16:25 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSkSLrmhb4AcKlWu@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hello@bryanbrattlof.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).