LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/5] staging: rtl8723bs: remove unused functions
@ 2021-08-27 16:12 Bryan Brattlof
  2021-08-27 16:13 ` [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Bryan Brattlof @ 2021-08-27 16:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Bryan Brattlof

Changes in v3:
 - Fix issue causing some emails to drop their In-Reply-To: header.

 (For the curious: NullMailer & my email provider where conspiring)

Changes in v2:
 - Remove build warnings I introduced in the previous version.

***

There is a lot of un-used code and un-needed abstractions leftover
in this driver from when (I assume) it could be compiled on more than
one kernel.

This series removes dead code and is one small step toward
refactoring how this driver interacts with the SDIO subsystem.

Bryan Brattlof (5):
  staging: rtl8723bs: remove sdio_write_mem()
  staging: rtl8723bs: remove sdio_writeN()
  staging: rtl8723bs: remove sdio_read_mem() and sdio_readN()
  staging: rtl8723bs: remove unused definitions from rtw_io.h
  staging: rtl8723bs: remove _read_port from _io_ops structure

 drivers/staging/rtl8723bs/hal/sdio_ops.c   | 116 ---------------------
 drivers/staging/rtl8723bs/include/rtw_io.h |  96 -----------------
 2 files changed, 212 deletions(-)

--
2.30.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem()
  2021-08-27 16:12 [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
@ 2021-08-27 16:13 ` Bryan Brattlof
  2021-08-27 16:26   ` Greg Kroah-Hartman
  2021-08-27 16:22 ` [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
  2021-08-27 16:25 ` Greg Kroah-Hartman
  2 siblings, 1 reply; 5+ messages in thread
From: Bryan Brattlof @ 2021-08-27 16:13 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Bryan Brattlof

The sdio_write_mem() function is unused in the driver. We can remove it.

Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
 drivers/staging/rtl8723bs/include/rtw_io.h |  1 -
 2 files changed, 12 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index a545832a468e..b784a390c8e1 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -356,16 +356,6 @@ static void sdio_read_mem(
 	sdio_readN(intfhdl, addr, cnt, rmem);
 }

-static void sdio_write_mem(
-	struct intf_hdl *intfhdl,
-	u32 addr,
-	u32 cnt,
-	u8 *wmem
-)
-{
-	sdio_writeN(intfhdl, addr, cnt, wmem);
-}
-
 /*
  * Description:
  *Read from RX FIFO
@@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
 	ops->_write16 = &sdio_write16;
 	ops->_write32 = &sdio_write32;
 	ops->_writeN = &sdio_writeN;
-	ops->_write_mem = &sdio_write_mem;
 	ops->_write_port = &sdio_write_port;
 }

diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
index e98083a07a66..87f36b7e880f 100644
--- a/drivers/staging/rtl8723bs/include/rtw_io.h
+++ b/drivers/staging/rtl8723bs/include/rtw_io.h
@@ -91,7 +91,6 @@ struct _io_ops {
 		int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);

 		void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
-		void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);

 		void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);

--
2.30.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/5] staging: rtl8723bs: remove unused functions
  2021-08-27 16:12 [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
  2021-08-27 16:13 ` [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
@ 2021-08-27 16:22 ` Bryan Brattlof
  2021-08-27 16:25 ` Greg Kroah-Hartman
  2 siblings, 0 replies; 5+ messages in thread
From: Bryan Brattlof @ 2021-08-27 16:22 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel

Sorry for the noise Greg,

On this day, August 27, 2021 thus sayeth Bryan Brattlof:
> Changes in v3:
>  - Fix issue causing some emails to drop their In-Reply-To: header.
>
>  (For the curious: NullMailer & my email provider where conspiring)
>

This turns out to be untrue :(

I've been testing my git-send-email setup on some friends without issue.
Somewhere between me and the mailing list In-Reply-To: headers are being
dropped.

I'll be back, but you can safely drop any patches from me today :(

Again sorry for the noise

~Bryan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/5] staging: rtl8723bs: remove unused functions
  2021-08-27 16:12 [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
  2021-08-27 16:13 ` [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
  2021-08-27 16:22 ` [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
@ 2021-08-27 16:25 ` Greg Kroah-Hartman
  2 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-08-27 16:25 UTC (permalink / raw)
  To: Bryan Brattlof; +Cc: linux-staging, linux-kernel

On Fri, Aug 27, 2021 at 04:12:56PM +0000, Bryan Brattlof wrote:
> Changes in v3:
>  - Fix issue causing some emails to drop their In-Reply-To: header.
> 
>  (For the curious: NullMailer & my email provider where conspiring)

Did not quite work, see:
	https://lore.kernel.org/r/cover.1630080164.git.hello@bryanbrattlof.com
as proof that only this message, and 1/5 were linked together.

The other 4 were out on their own :(

Also, there was no "v3" in the subject line as the documentation asks
for :(

v4 please?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem()
  2021-08-27 16:13 ` [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
@ 2021-08-27 16:26   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-08-27 16:26 UTC (permalink / raw)
  To: Bryan Brattlof; +Cc: linux-staging, linux-kernel

On Fri, Aug 27, 2021 at 04:13:15PM +0000, Bryan Brattlof wrote:
> The sdio_write_mem() function is unused in the driver. We can remove it.
> 
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
>  drivers/staging/rtl8723bs/include/rtw_io.h |  1 -
>  2 files changed, 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index a545832a468e..b784a390c8e1 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -356,16 +356,6 @@ static void sdio_read_mem(
>  	sdio_readN(intfhdl, addr, cnt, rmem);
>  }
> 
> -static void sdio_write_mem(
> -	struct intf_hdl *intfhdl,
> -	u32 addr,
> -	u32 cnt,
> -	u8 *wmem
> -)
> -{
> -	sdio_writeN(intfhdl, addr, cnt, wmem);
> -}
> -
>  /*
>   * Description:
>   *Read from RX FIFO
> @@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
>  	ops->_write16 = &sdio_write16;
>  	ops->_write32 = &sdio_write32;
>  	ops->_writeN = &sdio_writeN;
> -	ops->_write_mem = &sdio_write_mem;
>  	ops->_write_port = &sdio_write_port;
>  }
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
> index e98083a07a66..87f36b7e880f 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_io.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_io.h
> @@ -91,7 +91,6 @@ struct _io_ops {
>  		int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
> 
>  		void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> -		void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> 
>  		void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);
> 
> --
> 2.30.2
> 
> 
> 

THis changed from the previous version in ways you did not document
anywhere.  Please fix up in your v4 notes.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-27 16:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 16:12 [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
2021-08-27 16:13 ` [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
2021-08-27 16:26   ` Greg Kroah-Hartman
2021-08-27 16:22 ` [PATCH 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
2021-08-27 16:25 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).