LKML Archive on
help / color / mirror / Atom feed
From: Andy Shevchenko <>
To: Yury Norov <>
Cc: Petr Mladek <>,
	Rasmus Villemoes <>,
	Sergey Senozhatsky <>,
	Steven Rostedt <>,
Subject: Re: [PATCH] lib/vsprintf: add __putchar()
Date: Sun, 29 Aug 2021 16:36:13 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Aug 27, 2021 at 10:11:55AM -0700, Yury Norov wrote:
> There are 26 occurrences of the code snippet like this in the file :
> 	if (buf < end)
> 	        *buf = separator;
> 	++buf;
> This patch adds a helper function __putchar() to replace opencoding.
> It adds a lot to readability, and also saves 43 bytes of text on x86.

Last time I tried similar it failed the compilation.

Anyway, while you remove a lot of code I'm not sure it makes the code better
to read and understand. Also, we use the same idiom outside of this file.

I would ask Rasmus' opinion on this.

With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-08-29 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 17:11 Yury Norov
2021-08-29 13:36 ` Andy Shevchenko [this message]
2021-09-03 14:56   ` Steven Rostedt
2021-09-03 16:01     ` Yury Norov
2021-09-03 16:20       ` Steven Rostedt
2021-09-03 19:48       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] lib/vsprintf: add __putchar()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).