From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A66EC432BE for ; Thu, 2 Sep 2021 13:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C866610CD for ; Thu, 2 Sep 2021 13:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345254AbhIBN5i (ORCPT ); Thu, 2 Sep 2021 09:57:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:36070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234331AbhIBN5h (ORCPT ); Thu, 2 Sep 2021 09:57:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7C26760FD7; Thu, 2 Sep 2021 13:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630590999; bh=iaVXwyBRILapg+8HdQPSL9NVl17PaDxNtztyoI9tlCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xMjv4Eo8GN5K9tbMSTWIb620A3guSq1gCKdvs5pXttOj8jEFQOgTusUhyNwrSc7qF SB9wWbEaP9/bzSNGL224IdD7NMWMy4Z7ehVWFFPThBbQURYOxiyB0r1O49iVq0Px5U sUxFRjEvfcv6TTIReSUQbnzV+Hoip3qB6IcTQ4aQ= Date: Thu, 2 Sep 2021 15:56:36 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: Rob Herring , linuxarm@huawei.com, mauro.chehab@huawei.com, John Stultz , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] misc: hisi_hikey_usb: change the DT schema Message-ID: References: <20210902151053.7ddfbe3a@coco.lan> <20210902153820.5624b57f@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902153820.5624b57f@coco.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 03:38:20PM +0200, Mauro Carvalho Chehab wrote: > Em Thu, 2 Sep 2021 15:10:53 +0200 > Mauro Carvalho Chehab escreveu: > > > Em Thu, 2 Sep 2021 13:40:28 +0200 > > Greg Kroah-Hartman escreveu: > > > > > On Thu, Sep 02, 2021 at 01:28:35PM +0200, Mauro Carvalho Chehab wrote: > > > > As there's no upstream DT bindings for this driver, let's > > > > update its DT schema, while it is not too late. > > > > > > So this is for 5.15-final? > > > > It can either be for 5.15 or 5.16, as there aren't any compatible > > under arch/ which uses the DT schema there. All patches adding > > such compatible are on this series. So, whatever version this > > is applied should be OK. > > On a separate note, despite having "hisi_" on this driver's name, there's > nothing there that is really HiSilicon specific. What this driver does is > to control an USB HUB integrated inside a DT-based board, doing those > functions: > > - Power on/off the chip; > - reset the HUB; > - control its OTG switch; > - control power on/off for an USB type-C connector; > - set USB role as host or device. > > This is used on both HiKey 960 and HiKey 970 with the following > topology: > > +-----+ +--------+ +---------+ > | SoC | ---> | USB PHY| ---> | USB HUB | ---> USB 3.0 > +-----+ +--------+ +---------+ and type-C ports > > Both Kirin 960 and 970 SoCs have a Synapsys IP (DWC 3). > > Both HiKey 960 and 970 cards use Richtek RT1711H Type-C Chip Driver > as part of the USB PHY logic, but they use different USB HUBs: > > - HiKey 960 use a Microchip USB5734 HUB > - HiKey 970 use a TI TUSB8041 HUB > > While I'm not sure how generic this driver can be, I'm thinking that > maybe a future patch could rename it to 'generic-usb-hub' or > something similar - finding a good name is always the hardest > part :-) Try looking at: https://lore.kernel.org/r/20210813195228.2003500-1-mka@chromium.org for another example of this. thanks, greg k-h