LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: mka@chromium.org, swboyd@chromium.org,
bjorn.andersson@linaro.org, ulf.hansson@linaro.org,
rjw@rjwysocki.net, agross@kernel.org, ohad@wizery.com,
mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
rishabhb@codeaurora.org, sidgup@codeaurora.org
Subject: Re: [PATCH v6 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property
Date: Wed, 8 Sep 2021 08:51:53 -0500 [thread overview]
Message-ID: <YTi/+VIOuja9eLbl@robh.at.kernel.org> (raw)
In-Reply-To: <1630916637-4278-3-git-send-email-sibis@codeaurora.org>
On Mon, Sep 06, 2021 at 01:53:46PM +0530, Sibi Sankar wrote:
> The load state power-domain, used by the co-processors to notify the
> Always on Subsystem (AOSS) that a particular co-processor is up/down,
> suffers from the side-effect of changing states during suspend/resume.
> However the co-processors enter low-power modes independent to that of
> the application processor and their states are expected to remain
> unaltered across system suspend/resume cycles. To achieve this behavior
> let's drop the load state power-domain and replace them with the qmp
> property for all SoCs supporting low power mode signalling.
>
> Due to the current broken load state implementation, we can afford the
> binding breakage that ensues and the remoteproc functionality will remain
> the same when using newer kernels with older dtbs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
>
> v6:
> * Updated commit message to explain binding breakage. [Stephen]
>
> .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 61 +++++++++++-----------
> 1 file changed, 31 insertions(+), 30 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 0c112f3264a9..0d2b5bd4907a 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -93,6 +93,10 @@ properties:
> maxItems: 1
> description: Reference to the reserved-memory for the Hexagon core
>
> + qcom,qmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the AOSS side-channel message RAM.
> +
[...]
> @@ -511,6 +486,32 @@ allOf:
> - const: mss_restart
> - const: pdc_reset
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sc7180-mpss-pas
> + - qcom,sc8180x-adsp-pas
> + - qcom,sc8180x-cdsp-pas
> + - qcom,sc8180x-mpss-pas
> + - qcom,sm8150-adsp-pas
> + - qcom,sm8150-cdsp-pas
> + - qcom,sm8150-mpss-pas
> + - qcom,sm8150-slpi-pas
> + - qcom,sm8250-adsp-pas
> + - qcom,sm8250-cdsp-pas
> + - qcom,sm8250-slpi-pas
> + - qcom,sm8350-adsp-pas
> + - qcom,sm8350-cdsp-pas
> + - qcom,sm8350-mpss-pas
> + - qcom,sm8350-slpi-pas
> + then:
> + properties:
> + qcom,qmp:
> + items:
> + - description: Reference to the AOSS side-channel message RAM.
This doesn't do anything. The property is already allowed for all
compatibles. Perhaps you want to negate the if and put 'qcom,qmp: false'
here.
Rob
next prev parent reply other threads:[~2021-09-08 13:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 8:23 [PATCH v6 00/13] Use qmp_send to update co-processor load state Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 01/13] dt-bindings: soc: qcom: aoss: Drop the load state power-domain Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property Sibi Sankar
2021-09-08 13:51 ` Rob Herring [this message]
2021-09-16 3:13 ` Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 03/13] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 04/13] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 05/13] arm64: dts: qcom: sc7180: Use QMP property to control " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 06/13] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 07/13] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 08/13] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 09/13] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 10/13] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 11/13] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 12/13] dt-bindings: msm/dp: Remove aoss-qmp header Sibi Sankar
2021-09-06 8:23 ` [PATCH v6 13/13] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTi/+VIOuja9eLbl@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sibis@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--subject='Re: [PATCH v6 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).