LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
	Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: protect sleepq_len access by sleep_q.lock
Date: Fri, 17 Sep 2021 16:25:12 +0200	[thread overview]
Message-ID: <YUSlSDz3k9CZdGbP@kroah.com> (raw)
In-Reply-To: <30e138d5-fc51-bbcd-4dfc-3264c258c0bc@redhat.com>

On Mon, Sep 13, 2021 at 05:12:19PM +0200, Hans de Goede wrote:
> Hi Fabio,
> 
> On 9/13/21 3:39 PM, Fabio Aiuto wrote:
> > Hello Hans,
> > 
> > On Mon, Sep 13, 2021 at 03:24:44PM +0200, Hans de Goede wrote:
> >> Hi Fabio,
> >>
> >  
> >>> Note that sleep_q.lock is already taken inside
> >>> rtw_free_xmitframe_queue so we just wrap sleepq_len
> >>> access.
> >>>
> >>> Moved pxmitpriv->lock after sleep_q.lock release to
> >>> avoid locks nesting.
> > 
> >>>  	rtw_free_xmitframe_queue(pxmitpriv, &psta->sleep_q);
> >>> +	spin_lock_bh(&psta->sleep_q.lock);
> >>
> >> AFAICT this needs to be above the rtw_free_xmitframe_queue() ?
> > 
> > as I wrote on the changelog, the sleep_q.lock is already
> > taken inside rtw_free_xmitframe_queue. If I put the
> > sleep_q.lock above that function a soft lock occurs when
> > I disconnect.
> > 
> > So I put it just below rtw_free_xmitframe_queue.
> > 
> > Things works fine this way.
> > 
> > Please tell me if there's a best way to do it.
> 
> Hmm I see, this may work, but the sleepq_len access
> really should be protected by the same lock as the freeing
> of the queue is without dropping it in between.
> 
> That rtw_free_xmitframe_queue() takes the sleep_q.lock
> then to me that signals that other (higher-level) functions should
> not take sleep_q.lock at all, since this is then private to the
> functions operating on the sleep_q.
> 
> I've an idea how we we can possibly tackle this, but I'm not sure
> yet I will try to make some time to look into this tomorrow or
> the day after.

I'm just going to go and revert the original change here until you all
can sort it out :)

thanks,

greg k-h

  reply	other threads:[~2021-09-17 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 13:03 Fabio Aiuto
2021-09-13 13:24 ` Hans de Goede
2021-09-13 13:39   ` Fabio Aiuto
2021-09-13 15:12     ` Hans de Goede
2021-09-17 14:25       ` Greg KH [this message]
2021-09-17 14:27         ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUSlSDz3k9CZdGbP@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fabioaiuto83@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: [PATCH] staging: rtl8723bs: protect sleepq_len access by sleep_q.lock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).