LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tawah Peggy <tawahpeggy98@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '('.
Date: Fri, 17 Sep 2021 16:29:46 +0200	[thread overview]
Message-ID: <YUSmWgWX1FV+0TBh@kroah.com> (raw)
In-Reply-To: <20210915192110.GA325036@peggy-InsydeH2O-EFI-BIOS>

On Wed, Sep 15, 2021 at 08:21:10PM +0100, Tawah Peggy wrote:
> This patch fixes the checkpatch.pl warning;
> CHECK:lines should not end with '('.
> by replacing  ieee80211_frequency_to_channel()
>  with ieee80211_freq_to_channel()

Please properly cc: the needed people and mailing lists that the
scripts/get_maintainer.pl tool tells you to.

Also please work on your C knowledge some more before contributing to
the kernel.  The change you made here was obviously not tested and worst
of all, not even built tested as it breaks the build.

thanks,

greg k-h

      reply	other threads:[~2021-09-17 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 19:21 Tawah Peggy
2021-09-17 14:29 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUSmWgWX1FV+0TBh@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tawahpeggy98@gmail.com \
    --subject='Re: [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '\''('\''.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).