LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '('.
@ 2021-09-15 19:21 Tawah Peggy
  2021-09-17 14:29 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Tawah Peggy @ 2021-09-15 19:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel

This patch fixes the checkpatch.pl warning;
CHECK:lines should not end with '('.
by replacing  ieee80211_frequency_to_channel()
 with ieee80211_freq_to_channel()

Signed-off-by: Tawah Peggy <tawahpeggy98@gmail.com>
---
 drivers/staging/wlan-ng/cfg80211.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 7951bd63816f..d00f1c48e1a9 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -328,8 +328,7 @@ static int prism2_scan(struct wiphy *wiphy,
 		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
 		i++)
 		msg1.channellist.data.data[i] =
-			ieee80211_frequency_to_channel(
-				request->channels[i]->center_freq);
+			ieee80211_freq_to_channel(request->channels[i]->center_freq);
 	msg1.channellist.data.len = request->n_channels;
 
 	msg1.maxchanneltime.data = 250;
@@ -449,7 +448,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
 
 	/* Set the channel */
 	if (channel) {
-		chan = ieee80211_frequency_to_channel(channel->center_freq);
+		chan = ieee80211_freq_to_channel(channel->center_freq);
 		result = prism2_domibset_uint32(wlandev,
 						DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
 						chan);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '('.
  2021-09-15 19:21 [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '(' Tawah Peggy
@ 2021-09-17 14:29 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-09-17 14:29 UTC (permalink / raw)
  To: Tawah Peggy; +Cc: linux-kernel

On Wed, Sep 15, 2021 at 08:21:10PM +0100, Tawah Peggy wrote:
> This patch fixes the checkpatch.pl warning;
> CHECK:lines should not end with '('.
> by replacing  ieee80211_frequency_to_channel()
>  with ieee80211_freq_to_channel()

Please properly cc: the needed people and mailing lists that the
scripts/get_maintainer.pl tool tells you to.

Also please work on your C knowledge some more before contributing to
the kernel.  The change you made here was obviously not tested and worst
of all, not even built tested as it breaks the build.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-17 14:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 19:21 [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '(' Tawah Peggy
2021-09-17 14:29 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).