From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF70AC4332F for ; Thu, 23 Sep 2021 09:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91A8961241 for ; Thu, 23 Sep 2021 09:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240245AbhIWJuL (ORCPT ); Thu, 23 Sep 2021 05:50:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240268AbhIWJuK (ORCPT ); Thu, 23 Sep 2021 05:50:10 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0824C061757 for ; Thu, 23 Sep 2021 02:48:38 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id w29so15366922wra.8 for ; Thu, 23 Sep 2021 02:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=6+eKVp8taoHSdR1ibPn1ZGg0knOd1Pb0ImjfZkR19aI=; b=GTnuaG2v8n/EfVqZaGG/LrTewIRWMm7WeWMV3j9m4TQfzK6B0a4MoXuq7vYMKR5sRe OhoSOfgq+MGSmZTFC4dvGYouByjVRmagaBS3cEfzpPL+bxGgJi88cjdg6u/Q8NdSHlnr TpmTZ8f9YvBm66pwkXvPEHOTo1NB6sQLvtvYiAGLUfBVIxL8WW+ScDnGVm6p0pMIKP9r IjZoQkoj9ZzeOJzbf75qrDRdryulrO0JYGBlK59x+4zuwE2eYvEVvBFRwLgVuVscci48 Jto3AO2FZ9nqFAOzVOhfpYEIAnXDM00By37MSsbuC3c/36E4Y5BPxSno7NjlJkfb7C8+ KtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6+eKVp8taoHSdR1ibPn1ZGg0knOd1Pb0ImjfZkR19aI=; b=zGtC//Ye3GRNox4kt63aJAiO/XGWU48nRpaailbzZDGS7G1QGpuka8D4Rp32CCn6X3 rSJDsJ7YUG3cMC52RkqU1fjc5JYmkhUh5C+y1ePAtYj+Hs3SjWiA8tGKw6C+AcgE81Ik xQklI78Ct84iouKcZkEcmBCygDLv746tzlTsu571j9mF0A4CPGRLb5my1xj+Vk+eKT/u F/byGkGyFW21kdPq/Ah7uw/U6zssnBRD1I0/AUKnv6sSxsjhEBvPZRwGnjG0gMVvYu0u gY244jjC23Hi+LqyJSxsITBV0vThR6hWYd2ac9DnQLVQvgmHp4gM10qSRezVZlkyFqeS Lu+g== X-Gm-Message-State: AOAM532tO2ZwURgvqRhX3sOsM8+aJj/5SHkwPJ+s+4e4CIqHGeLsuK13 VzLBZTujo99JKxXLdqQVUyDl0A== X-Google-Smtp-Source: ABdhPJyibbde3vB1FCGt9d/JYvsj6NAS6zqNEXkWGRfCVwpJ0z2rvlY7kgpkBqqwzYJkFqg5Tz1gKg== X-Received: by 2002:a05:600c:4105:: with SMTP id j5mr3402523wmi.138.1632390517246; Thu, 23 Sep 2021 02:48:37 -0700 (PDT) Received: from google.com ([95.148.6.233]) by smtp.gmail.com with ESMTPSA id g22sm7965648wmp.39.2021.09.23.02.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 02:48:36 -0700 (PDT) Date: Thu, 23 Sep 2021 10:48:35 +0100 From: Lee Jones To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Daniel Thompson , Jingoo Han , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] backlight: propagate errors from get_brightness() Message-ID: References: <20210907124751.6404-1-linux@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210907124751.6404-1-linux@weissschuh.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > backlight.h documents "struct backlight_ops->get_brightness()" to return > a negative errno on failure. > So far these errors have not been handled in the backlight core. > This leads to negative values being exposed through sysfs although only > positive values are documented to be reported. > > Signed-off-by: Thomas Weißschuh > --- > > v1: https://lore.kernel.org/dri-devel/20210906215525.15418-1-linux@weissschuh.net/ > > v1 -> v2: > * use dev_err() instead of dev_warn() (Daniel Thompson) > * Finish logging format string with newline (Daniel Thompson) > * Log errno via dedicated error pointer format (Daniel Thompson) > > drivers/video/backlight/backlight.c | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog