From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2737EC433EF for ; Wed, 6 Oct 2021 16:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06C016112D for ; Wed, 6 Oct 2021 16:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbhJFQgP (ORCPT ); Wed, 6 Oct 2021 12:36:15 -0400 Received: from mga02.intel.com ([134.134.136.20]:46337 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhJFQgN (ORCPT ); Wed, 6 Oct 2021 12:36:13 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="213161376" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="213161376" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:34:21 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="439957347" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:34:18 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mY9ry-009FyW-JQ; Wed, 06 Oct 2021 19:34:14 +0300 Date: Wed, 6 Oct 2021 19:34:14 +0300 From: Andy Shevchenko To: Mark Brown Cc: Joe Perches , Pierre-Louis Bossart , Hans de Goede , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 06, 2021 at 05:20:04PM +0100, Mark Brown wrote: > On Wed, Oct 06, 2021 at 07:05:47PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 06, 2021 at 04:48:57PM +0100, Mark Brown wrote: > > > On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > > > > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > > > > > Some will complain about a lack of commit message. > > > > > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > > > > on these three patches to add it. > > > > > Mark, do you want me resend entire bunch(es) or just starting from these > > > > patches? Or...? > > > > If you're adding a commit message with automation it's probably not > > > adding any value. > > > What do you mean? I add it exceptionally for the same (by nature) patches. > > What do you expect to be altered in these three, if the idea behind the change > > is very well the same? > > I really don't care if there's a separate changelog for trivial patches > like this, it adds nothing of value. I see. In any case I'll add something meaningful here. -- With Best Regards, Andy Shevchenko