LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency"
@ 2021-09-21 14:34 Salvatore Bonaccorso
  2021-09-29 20:28 ` Salvatore Bonaccorso
  0 siblings, 1 reply; 3+ messages in thread
From: Salvatore Bonaccorso @ 2021-09-21 14:34 UTC (permalink / raw)
  To: gregkh; +Cc: linux-usb, linux-kernel, Ben Hutchings, Salvatore Bonaccorso

From: Ben Hutchings <ben@decadent.org.uk>

This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
USB_LED_TRIG.  This config symbol has bool type and enables extra code
in usb_common itself, not a separate driver.  Enabling it should not
force usb_common to be built-in!

Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 drivers/usb/common/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
index 5e8a04e3dd3c..b856622431a7 100644
--- a/drivers/usb/common/Kconfig
+++ b/drivers/usb/common/Kconfig
@@ -6,8 +6,7 @@ config USB_COMMON
 
 config USB_LED_TRIG
 	bool "USB LED Triggers"
-	depends on LEDS_CLASS && LEDS_TRIGGERS
-	select USB_COMMON
+	depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
 	help
 	  This option adds LED triggers for USB host and/or gadget activity.
 
-- 
2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency"
  2021-09-21 14:34 [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency" Salvatore Bonaccorso
@ 2021-09-29 20:28 ` Salvatore Bonaccorso
  2021-10-05 11:45   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Salvatore Bonaccorso @ 2021-09-29 20:28 UTC (permalink / raw)
  To: gregkh; +Cc: linux-usb, linux-kernel, Ben Hutchings

Hi Greg,

On Tue, Sep 21, 2021 at 04:34:42PM +0200, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> 
> This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
> USB_LED_TRIG.  This config symbol has bool type and enables extra code
> in usb_common itself, not a separate driver.  Enabling it should not
> force usb_common to be built-in!
> 
> Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---
>  drivers/usb/common/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
> index 5e8a04e3dd3c..b856622431a7 100644
> --- a/drivers/usb/common/Kconfig
> +++ b/drivers/usb/common/Kconfig
> @@ -6,8 +6,7 @@ config USB_COMMON
>  
>  config USB_LED_TRIG
>  	bool "USB LED Triggers"
> -	depends on LEDS_CLASS && LEDS_TRIGGERS
> -	select USB_COMMON
> +	depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
>  	help
>  	  This option adds LED triggers for USB host and/or gadget activity.

Sorry for bothering you again. Is this patch now ok, or do you need me
to change something else? Or do I miss something?

Regards,
Salvatore

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency"
  2021-09-29 20:28 ` Salvatore Bonaccorso
@ 2021-10-05 11:45   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-10-05 11:45 UTC (permalink / raw)
  To: Salvatore Bonaccorso; +Cc: linux-usb, linux-kernel, Ben Hutchings

On Wed, Sep 29, 2021 at 10:28:02PM +0200, Salvatore Bonaccorso wrote:
> Hi Greg,
> 
> On Tue, Sep 21, 2021 at 04:34:42PM +0200, Salvatore Bonaccorso wrote:
> > From: Ben Hutchings <ben@decadent.org.uk>
> > 
> > This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
> > USB_LED_TRIG.  This config symbol has bool type and enables extra code
> > in usb_common itself, not a separate driver.  Enabling it should not
> > force usb_common to be built-in!
> > 
> > Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> > ---
> >  drivers/usb/common/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
> > index 5e8a04e3dd3c..b856622431a7 100644
> > --- a/drivers/usb/common/Kconfig
> > +++ b/drivers/usb/common/Kconfig
> > @@ -6,8 +6,7 @@ config USB_COMMON
> >  
> >  config USB_LED_TRIG
> >  	bool "USB LED Triggers"
> > -	depends on LEDS_CLASS && LEDS_TRIGGERS
> > -	select USB_COMMON
> > +	depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> >  	help
> >  	  This option adds LED triggers for USB host and/or gadget activity.
> 
> Sorry for bothering you again. Is this patch now ok, or do you need me
> to change something else? Or do I miss something?

Nope, sorry for the delay, now applied.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-05 11:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 14:34 [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency" Salvatore Bonaccorso
2021-09-29 20:28 ` Salvatore Bonaccorso
2021-10-05 11:45   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).