LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: rtl8712: Statements should start on a tabstop
@ 2021-09-29 20:34 Dawid Esterhuizen
  2021-09-29 22:19 ` Bryan Brattlof
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Dawid Esterhuizen @ 2021-09-29 20:34 UTC (permalink / raw)
  To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
	linux-staging, linux-kernel

This path fixes four checkpatch.pl warnings:

Statements should start on a tabstop

Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
index 2e6afc7bb0a1..bc1287cc853e 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.h
+++ b/drivers/staging/rtl8712/rtl871x_xmit.h
@@ -182,11 +182,11 @@ struct sta_xmit_priv {
 };
 
 struct	hw_txqueue {
-	/*volatile*/ sint	head;
-	/*volatile*/ sint	tail;
-	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
-	/*volatile*/ sint      free_cmdsz;
-	/*volatile*/ sint	 txsz[8];
+  /*volatile*/ sint head;
+  /*volatile*/ sint tail;
+  /*volatile*/ sint free_sz;	/*in units of 64 bytes*/
+  /*volatile*/ sint free_cmdsz;
+  /*volatile*/ sint txsz[8];
 	uint	ff_hwaddr;
 	uint	cmd_hwaddr;
 	sint	ac_tag;
-- 
2.33.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8712: Statements should start on a tabstop
  2021-09-29 20:34 [PATCH] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
@ 2021-09-29 22:19 ` Bryan Brattlof
  2021-09-30  6:00 ` Greg Kroah-Hartman
  2021-09-30  9:25 ` Dan Carpenter
  2 siblings, 0 replies; 5+ messages in thread
From: Bryan Brattlof @ 2021-09-29 22:19 UTC (permalink / raw)
  To: Dawid Esterhuizen
  Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
	linux-staging, linux-kernel

Welcome Dawid!

On this day, September 29, 2021, thus sayeth Dawid Esterhuizen:
> This path fixes four checkpatch.pl warnings:
>
> Statements should start on a tabstop
>
> Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
>  };
>
>  struct	hw_txqueue {
> -	/*volatile*/ sint	head;
> -	/*volatile*/ sint	tail;
> -	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
> -	/*volatile*/ sint      free_cmdsz;
> -	/*volatile*/ sint	 txsz[8];
> +  /*volatile*/ sint head;
> +  /*volatile*/ sint tail;
> +  /*volatile*/ sint free_sz;	/*in units of 64 bytes*/
> +  /*volatile*/ sint free_cmdsz;
> +  /*volatile*/ sint txsz[8];
>

I'm thinking a better way to silence checkpatch.pl here would be to
remove the volatile comments. I find it easier to read when everything
is aligned, comment or not.

~Bryan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8712: Statements should start on a tabstop
  2021-09-29 20:34 [PATCH] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
  2021-09-29 22:19 ` Bryan Brattlof
@ 2021-09-30  6:00 ` Greg Kroah-Hartman
  2021-09-30  6:09   ` Joe Perches
  2021-09-30  9:25 ` Dan Carpenter
  2 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-09-30  6:00 UTC (permalink / raw)
  To: Dawid Esterhuizen
  Cc: Larry Finger, Florian Schilhabel, linux-staging, linux-kernel

On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
> 
> Statements should start on a tabstop
> 
> Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
>  };
>  
>  struct	hw_txqueue {
> -	/*volatile*/ sint	head;
> -	/*volatile*/ sint	tail;
> -	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
> -	/*volatile*/ sint      free_cmdsz;
> -	/*volatile*/ sint	 txsz[8];
> +  /*volatile*/ sint head;
> +  /*volatile*/ sint tail;
> +  /*volatile*/ sint free_sz;	/*in units of 64 bytes*/
> +  /*volatile*/ sint free_cmdsz;
> +  /*volatile*/ sint txsz[8];

I think you now have added a new checkpatch warning, right?

This is not the correct indentation anymore, why not work to see if you
can remove the volatile comment instead?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8712: Statements should start on a tabstop
  2021-09-30  6:00 ` Greg Kroah-Hartman
@ 2021-09-30  6:09   ` Joe Perches
  0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2021-09-30  6:09 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Dawid Esterhuizen
  Cc: Larry Finger, Florian Schilhabel, linux-staging, linux-kernel

On Thu, 2021-09-30 at 08:00 +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> > This path fixes four checkpatch.pl warnings:
> > 
> > Statements should start on a tabstop
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
[]
> > @@ -182,11 +182,11 @@ struct sta_xmit_priv {
> >  };
> >  
> > 
> >  struct	hw_txqueue {
> > -	/*volatile*/ sint	head;
> > -	/*volatile*/ sint	tail;
> > -	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
> > -	/*volatile*/ sint      free_cmdsz;
> > -	/*volatile*/ sint	 txsz[8];
> > +  /*volatile*/ sint head;
> > +  /*volatile*/ sint tail;
> > +  /*volatile*/ sint free_sz;	/*in units of 64 bytes*/
> > +  /*volatile*/ sint free_cmdsz;
> > +  /*volatile*/ sint txsz[8];
> 
> I think you now have added a new checkpatch warning, right?
> 
> This is not the correct indentation anymore, why not work to see if you
> can remove the volatile comment instead?

And maybe one day do

$ sed -i -e 's/\bsint\b/int/' drivers/staging/rtl8712/*.[ch]
$ sed -i 19d drivers/staging/rtl8712/basic_types.h



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8712: Statements should start on a tabstop
  2021-09-29 20:34 [PATCH] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
  2021-09-29 22:19 ` Bryan Brattlof
  2021-09-30  6:00 ` Greg Kroah-Hartman
@ 2021-09-30  9:25 ` Dan Carpenter
  2 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-09-30  9:25 UTC (permalink / raw)
  To: Dawid Esterhuizen
  Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
	linux-staging, linux-kernel

On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
> 
> Statements should start on a tabstop
> 
> Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
>  };
>  
>  struct	hw_txqueue {
> -	/*volatile*/ sint	head;
> -	/*volatile*/ sint	tail;
> -	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
> -	/*volatile*/ sint      free_cmdsz;
> -	/*volatile*/ sint	 txsz[8];
> +  /*volatile*/ sint head;
> +  /*volatile*/ sint tail;
> +  /*volatile*/ sint free_sz;	/*in units of 64 bytes*/
> +  /*volatile*/ sint free_cmdsz;
> +  /*volatile*/ sint txsz[8];

These "volatile" comments are wrong and pointless.  Just delete them
instead.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-30  9:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 20:34 [PATCH] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
2021-09-29 22:19 ` Bryan Brattlof
2021-09-30  6:00 ` Greg Kroah-Hartman
2021-09-30  6:09   ` Joe Perches
2021-09-30  9:25 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).