LKML Archive on
help / color / mirror / Atom feed
From: Matthew Wilcox <>
To: Marek Szyprowski <>
	"Andrew Morton" <>,
	김성훈 <>, "Song Liu" <>,
	"Rik van Riel" <>,
	"Kirill A . Shutemov" <>,
	"Johannes Weiner" <>,
	"Hillf Danton" <>,
	"Hugh Dickins" <>,
	"William Kucharski" <>,
	"Oleg Nesterov" <>,
	"Yang Shi" <>
Subject: Re: [PATCH] mm/thp: decrease nr_thps in file's mapping on THP split
Date: Tue, 12 Oct 2021 13:43:35 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Oct 12, 2021 at 02:02:37PM +0200, Marek Szyprowski wrote:
> Decrease nr_thps counter in file's mapping to ensure that the page cache
> won't be dropped excessively on file write access if page has been
> already splitted.
> Signed-off-by: Marek Szyprowski <>
> Fixes: 09d91cda0e82 ("mm,thp: avoid writes to file with THP in pagecache")
> Fixes: 06d3eff62d9d ("mm/thp: fix node page state in split_huge_page_to_list()")
> ---
> I've analyzed the code a few times but either I missed something or the
> nr_thps counter is not decremented during the THP split on non-shmem file
> pages.

This looks OK to me, but have you tested it?  If so, what workload did
you use?  The way you wrote this changelog makes it sound like you only
read the code and there have been rather too many bugs introduced recently
that way :-(

  reply	other threads:[~2021-10-12 12:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2021-10-12 12:02 ` Marek Szyprowski
2021-10-12 12:43   ` Matthew Wilcox [this message]
2021-10-13 10:47     ` Marek Szyprowski
2021-10-13 12:01       ` Matthew Wilcox
2021-10-13 21:44   ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm/thp: decrease nr_thps in file'\''s mapping on THP split' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).