LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
	NXP Linux Team <linux-imx@nxp.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs_check compatible oneOf error
Date: Wed, 10 Nov 2021 17:52:19 +0200	[thread overview]
Message-ID: <YYvqswlk59lI0fqH@ryzen> (raw)
In-Reply-To: <YWiMy5J/J/dxmkY4@robh.at.kernel.org>

On 21-10-14 15:02:19, Rob Herring wrote:
> On Wed, Oct 06, 2021 at 04:26:02PM +0300, Abel Vesa wrote:
> > Fix following dtbs_check error:
> > 
> > arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml:
> > i2c@5a800000: compatible: 'oneOf' conditional failed, one must be fixed:
> >         ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long
> >         Additional items are not allowed ('fsl,imx7ulp-lpi2c' was
> > unexpected)
> >         'fsl,imx8qxp-lpi2c' was expected
> >         From schema:
> > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > index 29b9447f3b84..acf2d5f45f4e 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > @@ -18,8 +18,11 @@ properties:
> >        - enum:
> >            - fsl,imx7ulp-lpi2c
> >            - fsl,imx8qm-lpi2c
> > +          - fsl,imx8qxp-lpi2c
> 
> Both with and without a fallback should not be valid.
> 
> Why are you changing fsl,imx8qxp-lpi2c when the error was for 
> fsl,imx8qm-lpi2c?
> 

Sorry for the late reply.

I assume the correct way would be like:

    oneOf:                                   
      - enum:                                
          - fsl,imx7ulp-lpi2c                
      - items:                               
	  - enum:                            
	      - fsl,imx8dxl-lpi2c            
	      - fsl,imx8qxp-lpi2c            
	      - fsl,imx8qm-lpi2c             
	  - const: fsl,imx7ulp-lpi2c         
				
Right ?

Since all the possible combinations are:
	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
	compatible = "fsl,imx8qm-lpi2c", "fsl,imx7ulp-lpi2c";
	compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
	compatible = "fsl,imx7ulp-lpi2c";


> >        - items:
> > -          - const: fsl,imx8qxp-lpi2c
> > +          - enum:
> > +              - fsl,imx8qm-lpi2c
> > +              - fsl,imx8qxp-lpi2c
> >            - const: fsl,imx7ulp-lpi2c
> >  
> >    reg:
> > -- 
> > 2.31.1
> > 
> >

  reply	other threads:[~2021-11-10 15:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 13:25 [PATCH v3 00/11] arm64: dts: Add i.MX8DXL initial support Abel Vesa
2021-10-06 13:25 ` [PATCH v3 01/11] arm64: dts: freescale: Add the top level dtsi support for imx8dxl Abel Vesa
2021-10-06 13:25 ` [PATCH v3 02/11] arm64: dts: imx8-ss-lsio: Add mu5a mailbox Abel Vesa
2021-10-06 13:25 ` [PATCH v3 03/11] arm64: dts: freescale: Add adma subsystem dtsi for imx8dxl Abel Vesa
2021-10-06 13:25 ` [PATCH v3 04/11] arm64: dts: freescale: Add the imx8dxl connectivity subsys dtsi Abel Vesa
2021-10-06 13:25 ` [PATCH v3 05/11] arm64: dts: freescale: Add ddr subsys dtsi for imx8dxl Abel Vesa
2021-10-06 13:25 ` [PATCH v3 06/11] arm64: dts: freescale: Add lsio " Abel Vesa
2021-10-06 13:26 ` [PATCH v3 07/11] arm64: dts: imx8dxl: Add i.MX8DXL evk board support Abel Vesa
2021-10-06 13:26 ` [PATCH v3 08/11] dt-bindings: fsl: scu: Add i.MX8DXL ocotp binding Abel Vesa
2021-10-14 19:56   ` Rob Herring
2021-10-06 13:26 ` [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs_check compatible oneOf error Abel Vesa
2021-10-14 20:02   ` Rob Herring
2021-11-10 15:52     ` Abel Vesa [this message]
2021-11-10 17:47       ` Abel Vesa
2021-10-06 13:26 ` [PATCH v3 10/11] dt-bindings: i2c: imx-lpi2c: Add i.MX8DXL compatible match Abel Vesa
2021-10-14 20:03   ` Rob Herring
2021-10-06 13:26 ` [PATCH v3 11/11] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible Abel Vesa
2021-10-14 20:04   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYvqswlk59lI0fqH@ryzen \
    --to=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs_check compatible oneOf error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).