LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Johan Hovold <johan@kernel.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] gpiolib: check the 'ngpios' property in core gpiolib code
Date: Wed, 24 Nov 2021 16:49:50 +0200	[thread overview]
Message-ID: <YZ5RDnDNIsWz+TC2@smile.fi.intel.com> (raw)
In-Reply-To: <YZ5QYsu2ed5FiSWE@smile.fi.intel.com>

On Wed, Nov 24, 2021 at 04:46:58PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 24, 2021 at 01:28:50PM +0100, Bartosz Golaszewski wrote:
> > Several drivers read the 'ngpios' device property on their own, but
> > since it's defined as a standard GPIO property in the device tree bindings
> > anyway, it's a good candidate for generalization. If the driver didn't
> > set its gc->ngpio, try to read the 'ngpios' property from the GPIO
> > device's firmware node before bailing out.

...

> What about the modified suggestion from previous version:
> 
> 	if (gc->ngpio == 0) {
> 		ret = device_property_read_u32(&gdev->dev, "ngpios", &ngpios);
> 		/*
> 		 * -ENODATA means that there is no property found and
> 		 * we want to issue the error message to the user. Besides
> 		 * that, we want to return different error code to state
> 		 * that supplied value is not valid.
> 		 */
> 		if (ret == -ENODATA)
> 			ngpios = 0;
> 		else if (ret)
> 			return ret;
> 
> 		gc->ngpio = ngpios;
> 	}
> 
> 	if (gc->ngpio == 0) {
> 		chip_err(gc, "tried to insert a GPIO chip with zero lines\n");
> 		ret = -EINVAL;
> 		goto err_free_descs;
> 	}
> 
> ?

If you okay to go with this code,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-11-24 14:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 12:28 [PATCH v3 1/2] gpiolib: improve coding style for local variables Bartosz Golaszewski
2021-11-24 12:28 ` [PATCH v3 2/2] gpiolib: check the 'ngpios' property in core gpiolib code Bartosz Golaszewski
2021-11-24 14:46   ` Andy Shevchenko
2021-11-24 14:49     ` Andy Shevchenko [this message]
2021-11-25 10:10     ` Bartosz Golaszewski
2021-11-25 11:18       ` Andy Shevchenko
2021-12-02 10:26         ` Bartosz Golaszewski
2021-11-24 14:35 ` [PATCH v3 1/2] gpiolib: improve coding style for local variables Andy Shevchenko
2021-11-24 14:42   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ5RDnDNIsWz+TC2@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=johan@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v3 2/2] gpiolib: check the '\''ngpios'\'' property in core gpiolib code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).