LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds
@ 2021-11-24 20:20 David Heidelberg
  2021-11-24 21:35 ` Andrew Lunn
  2021-12-01 22:24 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: David Heidelberg @ 2021-11-24 20:20 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Rob Herring
  Cc: ~okias/devicetree, David Heidelberg, netdev, devicetree, linux-kernel

Both are already used by HW and drivers inside Linux.

Fix warnings as:
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
        From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../devicetree/bindings/net/ethernet-controller.yaml          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index b0933a8c295a..95b5a3d77421 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -178,7 +178,7 @@ properties:
                   Duplex configuration. 0 for half duplex or 1 for
                   full duplex
 
-              - enum: [10, 100, 1000]
+              - enum: [10, 100, 1000, 2500, 10000]
                 description:
                   Link speed in Mbits/sec.
 
@@ -200,7 +200,7 @@ properties:
               description:
                 Link speed.
               $ref: /schemas/types.yaml#/definitions/uint32
-              enum: [10, 100, 1000]
+              enum: [10, 100, 1000, 2500, 10000]
 
             full-duplex:
               $ref: /schemas/types.yaml#/definitions/flag
-- 
2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds
  2021-11-24 20:20 [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds David Heidelberg
@ 2021-11-24 21:35 ` Andrew Lunn
  2021-12-01 22:24 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-11-24 21:35 UTC (permalink / raw)
  To: David Heidelberg
  Cc: David S. Miller, Jakub Kicinski, Rob Herring, ~okias/devicetree,
	netdev, devicetree, linux-kernel

On Wed, Nov 24, 2021 at 09:20:46PM +0100, David Heidelberg wrote:
> Both are already used by HW and drivers inside Linux.
> 
> Fix warnings as:
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
>         From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

This is valid for the binding, but not all Linux implementations of
fixed-link support > 1G. Only the phylink one does. But that is
outside the scope of the binding document.

You probably should list all speeds in
drivers/net/phy/phy-core.c:phy_setting settings[]. They are all valid
when using phylink and fixed-link.

	Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds
  2021-11-24 20:20 [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds David Heidelberg
  2021-11-24 21:35 ` Andrew Lunn
@ 2021-12-01 22:24 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-01 22:24 UTC (permalink / raw)
  To: David Heidelberg
  Cc: linux-kernel, Jakub Kicinski, ~okias/devicetree, David S. Miller,
	Rob Herring, devicetree, netdev

On Wed, 24 Nov 2021 21:20:46 +0100, David Heidelberg wrote:
> Both are already used by HW and drivers inside Linux.
> 
> Fix warnings as:
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
>         From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../devicetree/bindings/net/ethernet-controller.yaml          | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-01 22:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 20:20 [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds David Heidelberg
2021-11-24 21:35 ` Andrew Lunn
2021-12-01 22:24 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).