LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Maulik Shah <quic_mkshah@quicinc.com>
Cc: bjorn.andersson@linaro.org, rafael@kernel.org,
	daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	ulf.hansson@linaro.org, quic_lsrao@quicinc.com,
	rnayak@codeaurora.org, Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] sched/idle: Export cpu_idle_poll_ctrl() symbol
Date: Thu, 25 Nov 2021 10:51:50 +0100	[thread overview]
Message-ID: <YZ9ctgCBYJEEjuwt@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1637831676-32737-1-git-send-email-quic_mkshah@quicinc.com>

On Thu, Nov 25, 2021 at 02:44:36PM +0530, Maulik Shah wrote:
> Export cpu_idle_poll_ctrl() so that module drivers can use same.

This does not seem like a really safe interface to expose to the
world.

Surely the better solution is to rework things to not rely on this. I'm
fairly sure it's not hard to write a cpuidle driver that does much the
same.

  reply	other threads:[~2021-11-25  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  9:14 Maulik Shah
2021-11-25  9:51 ` Peter Zijlstra [this message]
2021-11-25 14:13   ` Maulik Shah
2021-11-25 17:26     ` Daniel Lezcano
2021-11-26  5:56       ` Maulik Shah
2021-11-26 11:22         ` Daniel Lezcano
2021-11-26 12:05     ` Ulf Hansson
2021-11-25  9:18 Maulik Shah
2021-11-26  9:15 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ9ctgCBYJEEjuwt@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=quic_lsrao@quicinc.com \
    --cc=quic_mkshah@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vincent.guittot@linaro.org \
    --subject='Re: [PATCH] sched/idle: Export cpu_idle_poll_ctrl() symbol' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).