LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel test robot <lkp@intel.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: ttm: correct ttm_range_manager kernel-doc notation
Date: Mon, 22 Nov 2021 11:14:44 +0800	[thread overview]
Message-ID: <YZsLJOUUBMnBUCu7@hr-amd> (raw)
In-Reply-To: <20211121155453.29736-1-rdunlap@infradead.org>

On Sun, Nov 21, 2021 at 11:54:52PM +0800, Randy Dunlap wrote:
> Fix kernel-doc warnings in ttm_range_manager.c:
> 
> drivers/gpu/drm/ttm/ttm_range_manager.c:144: warning: expecting prototype for ttm_range_man_init(). Prototype was for ttm_range_man_init_nocheck() instead
> drivers/gpu/drm/ttm/ttm_range_manager.c:178: warning: expecting prototype for ttm_range_man_fini(). Prototype was for ttm_range_man_fini_nocheck() instead
> 
> Also fix subsequent warnings from scripts/kernel-doc.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: dri-devel@lists.freedesktop.org

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/ttm/ttm_range_manager.c |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> --- linux-next-20211118.orig/drivers/gpu/drm/ttm/ttm_range_manager.c
> +++ linux-next-20211118/drivers/gpu/drm/ttm/ttm_range_manager.c
> @@ -128,15 +128,17 @@ static const struct ttm_resource_manager
>  };
>  
>  /**
> - * ttm_range_man_init
> + * ttm_range_man_init_nocheck - Initialise a generic range manager for the
> + * selected memory type.
>   *
>   * @bdev: ttm device
>   * @type: memory manager type
>   * @use_tt: if the memory manager uses tt
>   * @p_size: size of area to be managed in pages.
>   *
> - * Initialise a generic range manager for the selected memory type.
>   * The range manager is installed for this device in the type slot.
> + *
> + * Return: %0 on success or a negative error code on failure
>   */
>  int ttm_range_man_init_nocheck(struct ttm_device *bdev,
>  		       unsigned type, bool use_tt,
> @@ -166,12 +168,13 @@ int ttm_range_man_init_nocheck(struct tt
>  EXPORT_SYMBOL(ttm_range_man_init_nocheck);
>  
>  /**
> - * ttm_range_man_fini
> + * ttm_range_man_fini_nocheck - Remove the generic range manager from a slot
> + * and tear it down.
>   *
>   * @bdev: ttm device
>   * @type: memory manager type
>   *
> - * Remove the generic range manager from a slot and tear it down.
> + * Return: %0 on success or a negative error code on failure
>   */
>  int ttm_range_man_fini_nocheck(struct ttm_device *bdev,
>  		       unsigned type)

  reply	other threads:[~2021-11-22  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 15:54 Randy Dunlap
2021-11-22  3:14 ` Huang Rui [this message]
2021-11-22 20:33   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZsLJOUUBMnBUCu7@hr-amd \
    --to=ray.huang@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=rdunlap@infradead.org \
    --subject='Re: [PATCH] drm: ttm: correct ttm_range_manager kernel-doc notation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).