LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Aili Yao <yaoaili126@gmail.com>
Cc: pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
	jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, yaoaili@kingsoft.com
Subject: Re: [PATCH] KVM: LAPIC: Per vCPU control over kvm_can_post_timer_interrupt
Date: Mon, 22 Nov 2021 19:13:02 +0000	[thread overview]
Message-ID: <YZvrvmRnuDc1e+gi@google.com> (raw)
In-Reply-To: <20211122095619.000060d2@gmail.com>

On Mon, Nov 22, 2021, Aili Yao wrote:
> From: Aili Yao <yaoaili@kingsoft.com>
> 
> When we isolate some pyhiscal cores, We may not use them for kvm guests,
> We may use them for other purposes like DPDK, or we can make some kvm
> guests isolated and some not, the global judgement pi_inject_timer is
> not enough; We may make wrong decisions:
> 
> In such a scenario, the guests without isolated cores will not be
> permitted to use vmx preemption timer, and tscdeadline fastpath also be
> disabled, both will lead to performance penalty.
> 
> So check whether the vcpu->cpu is isolated, if not, don't post timer
> interrupt.
> 
> Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
> ---
>  arch/x86/kvm/lapic.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 759952dd1222..72dde5532101 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -34,6 +34,7 @@
>  #include <asm/delay.h>
>  #include <linux/atomic.h>
>  #include <linux/jump_label.h>
> +#include <linux/sched/isolation.h>
>  #include "kvm_cache_regs.h"
>  #include "irq.h"
>  #include "ioapic.h"
> @@ -113,7 +114,8 @@ static inline u32 kvm_x2apic_id(struct kvm_lapic *apic)
>  
>  static bool kvm_can_post_timer_interrupt(struct kvm_vcpu *vcpu)
>  {
> -	return pi_inject_timer && kvm_vcpu_apicv_active(vcpu);
> +	return pi_inject_timer && kvm_vcpu_apicv_active(vcpu) &&
> +		!housekeeping_cpu(vcpu->cpu, HK_FLAG_TIMER);

I don't think this is safe, vcpu->cpu will be -1 if the vCPU isn't scheduled in.
This also doesn't play nice with the admin forcing pi_inject_timer=1.  Not saying
there's a reasonable use case for doing that, but it's supported today and this
would break that behavior.  It would also lead to weird behavior if a vCPU were
migrated on/off a housekeeping vCPU.  Again, probably not a reasonable use case,
but I don't see anything that would outright prevent that behavior.

The existing behavior also feels a bit unsafe as pi_inject_timer is writable while
KVM is running, though I supposed that's orthogonal to this discussion.

Rather than check vcpu->cpu, is there an existing vCPU flag that can be queried,
e.g. KVM_HINTS_REALTIME?

>  }
>  
>  bool kvm_can_use_hv_timer(struct kvm_vcpu *vcpu)
> -- 
> 2.25.1
> 

  reply	other threads:[~2021-11-22 19:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  1:58 Aili Yao
2021-11-22 19:13 ` Sean Christopherson [this message]
2021-11-23  2:57   ` Wanpeng Li
2021-11-23  4:11     ` yaoaili [么爱利]
2021-11-23  6:24       ` Wanpeng Li
2021-11-23  7:02         ` Aili Yao
2021-11-23  7:22           ` Wanpeng Li
2021-11-23  8:18   ` Aili Yao
2021-11-29  3:28     ` Aili Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZvrvmRnuDc1e+gi@google.com \
    --to=seanjc@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    --cc=yaoaili126@gmail.com \
    --cc=yaoaili@kingsoft.com \
    --subject='Re: [PATCH] KVM: LAPIC: Per vCPU control over kvm_can_post_timer_interrupt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).