LKML Archive on
help / color / mirror / Atom feed
From: Petr Mladek <>
To: John Ogness <>,
	Sergey Senozhatsky <>,
	Steven Rostedt <>
Cc: Benjamin Herrenschmidt <>,
Subject: Re: [PATCH 0/5] printk/console: Registration code cleanup - part 1
Date: Mon, 6 Dec 2021 14:54:33 +0100	[thread overview]
Message-ID: <Ya4WGZT0emR96h0B@alley> (raw)
In-Reply-To: <>

On Mon 2021-11-22 14:26:44, Petr Mladek wrote:
> The console registration code has several twists that are hard to follow.
> It is result of various features added over the last few decades.
> I have already spent many days to understand all the effects and
> the desired behavior. I am always scared to touch the console registration
> code even after years working as printk maintainer.
> There were several changes in the code that had to be reverted because
> they caused regression, for example:
>    + commit dac8bbbae1d0ccba96402 ("Revert "printk: fix double printing
>      with earlycon")
>    + commit c6c7d83b9c9e6a8b3e6d ("Revert "console: don't prefer first
>      registered if DT specifies stdout-path")
> This patchset removes the most tricky twists from my POV. I have worked
> on it when time permitted since January. I have spent most of the time
> writing the commit message, understanding, and explaining the effects.
> I am not sure if I succeeded but it is time to send this.
> Behavior change:
> There is one behavior change caused by 4th patch. I consider it bug fix.
> It should be acceptable. See the commit message for more details.

I am afraid that the patchset is not easy to review. I decided to help
a bit and give it a spin in linux-next.

The patchset has been committed into printk/linux.git, branch
console-registration-cleanup. It should appear in linux-next
during the next respin.

I am going to take it back when anyone reports any problem that
can't be fixed easily.

Any feedback is still appreciated.

Best Regards,

      parent reply	other threads:[~2021-12-06 13:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 13:26 Petr Mladek
2021-11-22 13:26 ` [PATCH 1/5] printk/console: Split out code that enables default console Petr Mladek
2021-11-23  2:10   ` Sergey Senozhatsky
2021-11-23 10:21     ` Petr Mladek
2021-11-22 13:26 ` [PATCH 2/5] printk/console: Rename has_preferred_console to need_default_console Petr Mladek
2021-11-23  2:15   ` Sergey Senozhatsky
2021-11-23 10:51     ` Petr Mladek
2021-11-22 13:26 ` [PATCH 3/5] printk/console: Remove unnecessary need_default_console manipulation Petr Mladek
2021-11-22 13:26 ` [PATCH 4/5] printk/console: Remove need_default_console variable Petr Mladek
2021-11-22 13:26 ` [PATCH 5/5] printk/console: Clean up boot console handling in register_console() Petr Mladek
2021-12-06 13:54 ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ya4WGZT0emR96h0B@alley \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/5] printk/console: Registration code cleanup - part 1' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).