LKML Archive on
help / color / mirror / Atom feed
From: Greg KH <>
To: Johan Hovold <>
	Maarten Brock <>,, Karoly Pados <>
Subject: Re: [PATCH] USB: serial: cp210x: fix CP2105 GPIO registration
Date: Fri, 26 Nov 2021 10:56:54 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Nov 26, 2021 at 10:43:48AM +0100, Johan Hovold wrote:
> When generalising GPIO support and adding support for CP2102N, the GPIO
> registration for some CP2105 devices accidentally broke. Specifically,
> when all the pins of a port are in "modem" mode, and thus unavailable
> for GPIO use, the GPIO chip would now be registered without having
> initialised the number of GPIO lines. This would in turn be rejected by
> gpiolib and some errors messages would be printed (but importantly probe
> would still succeed).
> Fix this by initialising the number of GPIO lines before registering the
> GPIO chip.
> Note that as for the other device types, and as when all CP2105 pins are
> muxed for LED function, the GPIO chip is registered also when no pins
> are available for GPIO use.
> Reported-by: Maarten Brock <>
> Link:
> Fixes: c8acfe0aadbe ("USB: serial: cp210x: implement GPIO support for CP2102N")
> Cc:      # 4.19
> Cc: Karoly Pados <>
> Signed-off-by: Johan Hovold <>

Reviewed-by: Greg Kroah-Hartman <>

  reply	other threads:[~2021-11-26  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  9:43 Johan Hovold
2021-11-26  9:56 ` Greg KH [this message]
2021-11-26 12:37 ` Maarten Brock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] USB: serial: cp210x: fix CP2105 GPIO registration' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).