LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To:
@ 2021-11-25 20:48 Arnaldo Carvalho de Melo
  2021-11-26  9:53 ` Heiko Carstens
  0 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-11-25 20:48 UTC (permalink / raw)
  To: Vasily Gorbik
  Cc: Heiko Carstens, Adrian Hunter, Jiri Olsa, Namhyung Kim,
	linux-perf-users, Linux Kernel Mailing List

To pick the changes in this cset:

  6c122360cf2f4c5a ("s390: wire up sys_futex_waitv system call")

That add support for this new syscall in tools such as 'perf trace'.

For instance, this is now possible (adapted from the x86_64 test output):

  # perf trace -e futex_waitv
  ^C#
  # perf trace -v -e futex_waitv
  event qualifier tracepoint filter: (common_pid != 807333 && common_pid != 3564) && (id == 449)
  ^C#
  # perf trace -v -e futex* --max-events 10
  event qualifier tracepoint filter: (common_pid != 812168 && common_pid != 3564) && (id == 238 || id == 449)
           ? (         ): Timer/219310  ... [continued]: futex())                                            = -1 ETIMEDOUT (Connection timed out)
       0.012 ( 0.002 ms): Timer/219310 futex(uaddr: 0x7fd0b152d3c8, op: WAKE|PRIVATE_FLAG, val: 1)           = 0
       0.024 ( 0.060 ms): Timer/219310 futex(uaddr: 0x7fd0b152d420, op: WAIT_BITSET|PRIVATE_FLAG, utime: 0x7fd0b1657840, val3: MATCH_ANY) = 0
       0.086 ( 0.001 ms): Timer/219310 futex(uaddr: 0x7fd0b152d3c8, op: WAKE|PRIVATE_FLAG, val: 1)           = 0
       0.088 (         ): Timer/219310 futex(uaddr: 0x7fd0b152d424, op: WAIT_BITSET|PRIVATE_FLAG, utime: 0x7fd0b1657840, val3: MATCH_ANY) ...
       0.075 ( 0.005 ms): Web Content/219299 futex(uaddr: 0x7fd0b152d420, op: WAKE|PRIVATE_FLAG, val: 1)     = 1
       0.169 ( 0.004 ms): Web Content/219299 futex(uaddr: 0x7fd0b152d424, op: WAKE|PRIVATE_FLAG, val: 1)     = 1
       0.088 ( 0.089 ms): Timer/219310  ... [continued]: futex())                                            = 0
       0.179 ( 0.001 ms): Timer/219310 futex(uaddr: 0x7fd0b152d3c8, op: WAKE|PRIVATE_FLAG, val: 1)           = 0
       0.181 (         ): Timer/219310 futex(uaddr: 0x7fd0b152d420, op: WAIT_BITSET|PRIVATE_FLAG, utime: 0x7fd0b1657840, val3: MATCH_ANY) ...
  #

That is the filter expression attached to the raw_syscalls:sys_{enter,exit}
tracepoints.

  $ grep futex tools/perf/arch/s390/entry/syscalls/syscall.tbl
  238  common	futex			sys_futex			sys_futex_time32
  422	32	futex_time64		-				sys_futex
  449  common	futex_waitv		sys_futex_waitv			sys_futex_waitv
  $

This addresses this perf build warnings:

  Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
  diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl

Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/arch/s390/entry/syscalls/syscall.tbl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/arch/s390/entry/syscalls/syscall.tbl b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
index df5261e5cfe1f28d..ed9c5c2eafad700c 100644
--- a/tools/perf/arch/s390/entry/syscalls/syscall.tbl
+++ b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
@@ -451,3 +451,4 @@
 446  common	landlock_restrict_self	sys_landlock_restrict_self	sys_landlock_restrict_self
 # 447 reserved for memfd_secret
 448  common	process_mrelease	sys_process_mrelease		sys_process_mrelease
+449  common	futex_waitv		sys_futex_waitv			sys_futex_waitv
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To:
  2021-11-25 20:48 [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To: Arnaldo Carvalho de Melo
@ 2021-11-26  9:53 ` Heiko Carstens
  2021-11-26 10:01   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 5+ messages in thread
From: Heiko Carstens @ 2021-11-26  9:53 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Vasily Gorbik, Adrian Hunter, Jiri Olsa, Namhyung Kim,
	linux-perf-users, Linux Kernel Mailing List

Hi Arnaldo,

> To pick the changes in this cset:
> 
>   6c122360cf2f4c5a ("s390: wire up sys_futex_waitv system call")
> 
> That add support for this new syscall in tools such as 'perf trace'.
...
> This addresses this perf build warnings:
> 
>   Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
>   diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl
> 
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/arch/s390/entry/syscalls/syscall.tbl | 1 +
>  1 file changed, 1 insertion(+)

I can happily pick this up for the s390 tree, but I'm not sure if that
is want you want?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To:
  2021-11-26  9:53 ` Heiko Carstens
@ 2021-11-26 10:01   ` Arnaldo Carvalho de Melo
  2021-11-26 11:29     ` Heiko Carstens
  0 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-11-26 10:01 UTC (permalink / raw)
  To: Heiko Carstens, Arnaldo Carvalho de Melo
  Cc: Vasily Gorbik, Adrian Hunter, Jiri Olsa, Namhyung Kim,
	linux-perf-users, Linux Kernel Mailing List



On November 26, 2021 6:53:07 AM GMT-03:00, Heiko Carstens <hca@linux.ibm.com> wrote:
>Hi Arnaldo,
>
>> To pick the changes in this cset:
>> 
>>   6c122360cf2f4c5a ("s390: wire up sys_futex_waitv system call")
>> 
>> That add support for this new syscall in tools such as 'perf trace'.
>...
>> This addresses this perf build warnings:
>> 
>>   Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
>>   diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl
>> 
>> Cc: Heiko Carstens <hca@linux.ibm.com>
>> Cc: Vasily Gorbik <gor@linux.ibm.com>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>> ---
>>  tools/perf/arch/s390/entry/syscalls/syscall.tbl | 1 +
>>  1 file changed, 1 insertion(+)
>
>I can happily pick this up for the s390 tree, but I'm not sure if that
>is want you want?

Just FYI and to give the opportunity to people to chime in in case something is wrong somehow.

Also to advertise the feature.

I'm pushing this upstream myself,

Thanks,

- Arnaldo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To:
  2021-11-26 10:01   ` Arnaldo Carvalho de Melo
@ 2021-11-26 11:29     ` Heiko Carstens
  2021-11-26 18:50       ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 5+ messages in thread
From: Heiko Carstens @ 2021-11-26 11:29 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Arnaldo Carvalho de Melo, Vasily Gorbik, Adrian Hunter,
	Jiri Olsa, Namhyung Kim, linux-perf-users,
	Linux Kernel Mailing List

On Fri, Nov 26, 2021 at 07:01:16AM -0300, Arnaldo Carvalho de Melo wrote:
> >> To pick the changes in this cset:
> >> 
> >>   6c122360cf2f4c5a ("s390: wire up sys_futex_waitv system call")
> >> 
> >> That add support for this new syscall in tools such as 'perf trace'.
> >...
> >> This addresses this perf build warnings:
> >> 
> >>   Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
> >>   diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl
> >> 
> >> Cc: Heiko Carstens <hca@linux.ibm.com>
> >> Cc: Vasily Gorbik <gor@linux.ibm.com>
> >> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >> ---
> >>  tools/perf/arch/s390/entry/syscalls/syscall.tbl | 1 +
> >>  1 file changed, 1 insertion(+)
> >
> >I can happily pick this up for the s390 tree, but I'm not sure if that
> >is want you want?
> 
> Just FYI and to give the opportunity to people to chime in in case something is wrong somehow.
> 
> Also to advertise the feature.
> 
> I'm pushing this upstream myself,

Thanks for taking care of this! FWIW:

Acked-by: Heiko Carstens <hca@linux.ibm.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To:
  2021-11-26 11:29     ` Heiko Carstens
@ 2021-11-26 18:50       ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-11-26 18:50 UTC (permalink / raw)
  To: Heiko Carstens
  Cc: Arnaldo Carvalho de Melo, Vasily Gorbik, Adrian Hunter,
	Jiri Olsa, Namhyung Kim, linux-perf-users,
	Linux Kernel Mailing List

Em Fri, Nov 26, 2021 at 12:29:16PM +0100, Heiko Carstens escreveu:
> On Fri, Nov 26, 2021 at 07:01:16AM -0300, Arnaldo Carvalho de Melo wrote:
> > >> To pick the changes in this cset:
> > >> 
> > >>   6c122360cf2f4c5a ("s390: wire up sys_futex_waitv system call")
> > >> 
> > >> That add support for this new syscall in tools such as 'perf trace'.
> > >...
> > >> This addresses this perf build warnings:
> > >> 
> > >>   Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
> > >>   diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl
> > >> 
> > >> Cc: Heiko Carstens <hca@linux.ibm.com>
> > >> Cc: Vasily Gorbik <gor@linux.ibm.com>
> > >> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > >> ---
> > >>  tools/perf/arch/s390/entry/syscalls/syscall.tbl | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >
> > >I can happily pick this up for the s390 tree, but I'm not sure if that
> > >is want you want?
> > 
> > Just FYI and to give the opportunity to people to chime in in case something is wrong somehow.
> > 
> > Also to advertise the feature.
> > 
> > I'm pushing this upstream myself,
> 
> Thanks for taking care of this! FWIW:
> 
> Acked-by: Heiko Carstens <hca@linux.ibm.com>

Thanks, acked-by tag collected :-)

- Arnaldo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-30 13:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 20:48 [FYI][PATCH 1/1] tools headers UAPI: Sync s390 syscall table file changed by new futex_waitv syscall Reply-To: Arnaldo Carvalho de Melo
2021-11-26  9:53 ` Heiko Carstens
2021-11-26 10:01   ` Arnaldo Carvalho de Melo
2021-11-26 11:29     ` Heiko Carstens
2021-11-26 18:50       ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).