LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Satya Priya <quic_c_skakit@quicinc.com>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	mka@chromium.org, swboyd@chromium.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	satya priya <skakit@codeaurora.org>
Subject: Re: [PATCH V3 2/4] leds: Add pm8350c support to Qualcomm LPG driver
Date: Thu, 17 Feb 2022 14:26:20 -0800	[thread overview]
Message-ID: <Yg7LjJFi51cmDUQr@ripper> (raw)
In-Reply-To: <1635507893-25490-3-git-send-email-quic_c_skakit@quicinc.com>

On Fri 29 Oct 04:44 PDT 2021, Satya Priya wrote:

> From: satya priya <skakit@codeaurora.org>
> 
> Add pm8350c compatible and lpg_data to the driver.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>

Sorry for the OCD, but I would really like for you to capitalize 's' and
'p' in your name.

> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in V2:
>  - Added const for lpg_channel_data[] struct.
> 
> Changes in V3:
>  - Correct the num_channels and add respective base addresses.
> 
>  drivers/leds/rgb/leds-qcom-lpg.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
> index 45ef4ec..ad99a9b 100644
> --- a/drivers/leds/rgb/leds-qcom-lpg.c
> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
> @@ -1275,9 +1275,22 @@ static const struct lpg_data pm8150l_lpg_data = {
>  	},
>  };
>  
> +static const struct lpg_data pm8350c_pwm_data = {
> +	.pwm_9bit_mask = BIT(2),

As you might have seen in v12 I dropped pwm_9bit_mask.

> +

Afaict there's a tri-channel current sink in pm8350c as well, so you
should have:

        .triled_base = 0xef00,

And then associated .triled_mask in the relevant channels.

Regards,
Bjorn

> +	.num_channels = 4,
> +	.channels = (const struct lpg_channel_data[]) {
> +		{ .base = 0xe800 },
> +		{ .base = 0xe900 },
> +		{ .base = 0xea00 },
> +		{ .base = 0xeb00 },
> +	},
> +};
> +
>  static const struct of_device_id lpg_of_table[] = {
>  	{ .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data },
>  	{ .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data },
> +	{ .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data },
>  	{ .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
>  	{ .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
>  	{ .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },
> -- 
> 2.7.4
> 

  parent reply	other threads:[~2022-02-17 22:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 11:44 [PATCH V3 0/4] Add PM8350C PMIC PWM support for backlight Satya Priya
2021-10-29 11:44 ` [PATCH V3 1/4] dt-bindings: leds: Add pm8350c pmic support Satya Priya
2021-10-29 17:23   ` Trilok Soni
2021-11-26  8:57     ` Satya Priya Kakitapalli (Temp)
2021-10-29 11:44 ` [PATCH V3 2/4] leds: Add pm8350c support to Qualcomm LPG driver Satya Priya
2021-10-29 17:23   ` Trilok Soni
2021-10-29 19:01   ` Stephen Boyd
2022-02-17 22:26   ` Bjorn Andersson [this message]
2022-02-22  4:45     ` Satya Priya Kakitapalli (Temp)
2021-10-29 11:44 ` [PATCH V3 3/4] arm64: dts: qcom: pm8350c: Add pwm support Satya Priya
2021-10-29 19:02   ` Stephen Boyd
2021-10-29 11:44 ` [PATCH V3 4/4] arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2 Satya Priya
2021-10-29 19:02   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yg7LjJFi51cmDUQr@ripper \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=pavel@ucw.cz \
    --cc=quic_c_skakit@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=skakit@codeaurora.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH V3 2/4] leds: Add pm8350c support to Qualcomm LPG driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).