LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tong Zhang <ztong0001@gmail.com>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: macb: fix use after free on rmmod
Date: Thu, 9 Sep 2021 09:53:06 +0200	[thread overview]
Message-ID: <a0f3f83d-0c83-5521-a608-026423e1c69e@microchip.com> (raw)
In-Reply-To: <20210908190232.573178-1-ztong0001@gmail.com>

On 08/09/2021 at 21:02, Tong Zhang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> plat_dev->dev->platform_data is released by platform_device_unregister(),
> use of pclk and hclk is a use-after-free. Since device unregister won't
> need a clk device we adjust the function call sequence to fix this issue.
> 
> [   31.261225] BUG: KASAN: use-after-free in macb_remove+0x77/0xc6 [macb_pci]
> [   31.275563] Freed by task 306:
> [   30.276782]  platform_device_release+0x25/0x80
> 
> Suggested-by: Nicolas Ferre <Nicolas.Ferre@microchip.com>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Tong Zhang.
Regards,
   Nicolas

> ---
> v2: switch lines to fix the issue instead
> 
>   drivers/net/ethernet/cadence/macb_pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c
> index 8b7b59908a1a..f66d22de5168 100644
> --- a/drivers/net/ethernet/cadence/macb_pci.c
> +++ b/drivers/net/ethernet/cadence/macb_pci.c
> @@ -111,9 +111,9 @@ static void macb_remove(struct pci_dev *pdev)
>          struct platform_device *plat_dev = pci_get_drvdata(pdev);
>          struct macb_platform_data *plat_data = dev_get_platdata(&plat_dev->dev);
> 
> -       platform_device_unregister(plat_dev);
>          clk_unregister(plat_data->pclk);
>          clk_unregister(plat_data->hclk);
> +       platform_device_unregister(plat_dev);
>   }
> 
>   static const struct pci_device_id dev_id_table[] = {
> --
> 2.25.1
> 


-- 
Nicolas Ferre

  reply	other threads:[~2021-09-09  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 20:29 [PATCH v1] " Tong Zhang
2021-09-08  7:27 ` Nicolas.Ferre
2021-09-08 19:02   ` [PATCH v2] " Tong Zhang
2021-09-09  7:53     ` Nicolas Ferre [this message]
2021-09-09 10:00     ` patchwork-bot+netdevbpf
2021-09-08 19:02   ` [PATCH v1] " Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0f3f83d-0c83-5521-a608-026423e1c69e@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ztong0001@gmail.com \
    --subject='Re: [PATCH v2] net: macb: fix use after free on rmmod' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).