LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: akpm@linux-foundation.org, broonie@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
	mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
	Nicholas Piggin <npiggin@gmail.com>
Subject: Re: mmotm 2021-08-02-18-51 uploaded (struct user_struct when CONFIG_EPOLL is not set)
Date: Mon, 2 Aug 2021 22:49:32 -0700	[thread overview]
Message-ID: <a1a499b0-a5f6-4c20-dbb1-d5f0a20df818@infradead.org> (raw)
In-Reply-To: <ff69bf0c-39b2-1eb0-67cb-5a596c2049d8@infradead.org>

On 8/2/21 10:41 PM, Randy Dunlap wrote:
> On 8/2/21 6:52 PM, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2021-08-02-18-51 has been uploaded to
>>
>>     https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release 
>> (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is 
>> duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
>>
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
>>
> 
> I am seeing build errors on i386 or x86_64 when CONFIG_EPOLL is not set:
> 
> ../kernel/user.c: In function ‘free_user’:
> ../kernel/user.c:141:30: error: ‘struct user_struct’ has no member named 
> ‘epoll_watches’; did you mean ‘nr_watches’?
>    percpu_counter_destroy(&up->epoll_watches);
>                                ^~~~~~~~~~~~~
>                                nr_watches
> In file included from ../include/linux/sched/user.h:7:0,
>                   from ../kernel/user.c:17:
> ../kernel/user.c: In function ‘alloc_uid’:
> ../kernel/user.c:189:33: error: ‘struct user_struct’ has no member named 
> ‘epoll_watches’; did you mean ‘nr_watches’?
>     if (percpu_counter_init(&new->epoll_watches, 0, GFP_KERNEL)) {
>                                   ^
> ../include/linux/percpu_counter.h:38:25: note: in definition of macro 
> ‘percpu_counter_init’
>     __percpu_counter_init(fbc, value, gfp, &__key);  \
>                           ^~~
> ../kernel/user.c:203:33: error: ‘struct user_struct’ has no member named 
> ‘epoll_watches’; did you mean ‘nr_watches’?
>      percpu_counter_destroy(&new->epoll_watches);
>                                   ^~~~~~~~~~~~~
>                                   nr_watches
> In file included from ../include/linux/sched/user.h:7:0,
>                   from ../kernel/user.c:17:
> ../kernel/user.c: In function ‘uid_cache_init’:
> ../kernel/user.c:225:37: error: ‘struct user_struct’ has no member named 
> ‘epoll_watches’; did you mean ‘nr_watches’?
>    if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL))
>                                       ^
> ../include/linux/percpu_counter.h:38:25: note: in definition of macro 
> ‘percpu_counter_init’
>     __percpu_counter_init(fbc, value, gfp, &__key);  \
>                           ^~~
> 
> 

Also do this change in kernel/user.c please:

         if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL))
-               panic("percpu cpunter alloc failed");
+               panic("percpu counter alloc failed");


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2021-08-03  5:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  1:52 mmotm 2021-08-02-18-51 uploaded akpm
2021-08-03  5:41 ` mmotm 2021-08-02-18-51 uploaded (struct user_struct when CONFIG_EPOLL is not set) Randy Dunlap
2021-08-03  5:49   ` Randy Dunlap [this message]
2021-08-03  5:59 ` mmotm 2021-08-02-18-51 uploaded Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1a499b0-a5f6-4c20-dbb1-d5f0a20df818@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mm-commits@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: mmotm 2021-08-02-18-51 uploaded (struct user_struct when CONFIG_EPOLL is not set)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).