From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F946C4338F for ; Wed, 11 Aug 2021 03:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16E9C60E78 for ; Wed, 11 Aug 2021 03:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233136AbhHKDN7 (ORCPT ); Tue, 10 Aug 2021 23:13:59 -0400 Received: from mail-pj1-f44.google.com ([209.85.216.44]:39670 "EHLO mail-pj1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232498AbhHKDN5 (ORCPT ); Tue, 10 Aug 2021 23:13:57 -0400 Received: by mail-pj1-f44.google.com with SMTP id u21-20020a17090a8915b02901782c36f543so7395021pjn.4 for ; Tue, 10 Aug 2021 20:13:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PPgnnFQnDyvLSvdk61y23ETmSlhBYVAGUD4y9vVkgQ4=; b=CAf5P+tqnI0SNZ8l77EvZIcKNYqbsgNas4sXr9GdkoXd+WuppY2whVJuZThneBlDE2 TU/Dt3MOD7DnfGc6G3O9BMh58KhgS7NTTVu/zPTQ/wxwGg7kwbP333f/UaM3l040sg8f SlrnlgzyKPgh2NHkOUIoLeBrGXk9aMNkRj9GRWsR74bypVpMDD37uQqldSTt7BcsgEPD XlD05EJtibWKNot90UojkdMFtsh0fKO+7xObjb4ajqPpjl2QG4Z+JSgDnEPyCp5xL8UU NipUYNMaY//yF7g+VI7EPWmXhVEO1+lFkZYsDq8HLybK+sh8yKVUdTRoopX7doK21A5W mdNw== X-Gm-Message-State: AOAM5338YuWwIelTanjIOjx4G/V3LpT8C8inJpIxhaXt8xLliQEmqbD6 lLx9FC9e5K5bI72VxbeYCIQ= X-Google-Smtp-Source: ABdhPJxFbY23P72cJAIj80HfRyKTrmNg7udkm68SEFkMyz8yR+4UfqiqaQPq6OjXd702QkePKnIxig== X-Received: by 2002:a17:902:da8a:b029:12c:4261:a2d6 with SMTP id j10-20020a170902da8ab029012c4261a2d6mr4576500plx.50.1628651614412; Tue, 10 Aug 2021 20:13:34 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:2e5f:88b1:dfed:ae53? ([2601:647:4000:d7:2e5f:88b1:dfed:ae53]) by smtp.gmail.com with ESMTPSA id q1sm26428550pfn.6.2021.08.10.20.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 20:13:33 -0700 (PDT) Subject: Re: [PATCH v4 3/3] configfs: Add unit tests To: Brendan Higgins , Christoph Hellwig Cc: Joel Becker , linux-kernel@vger.kernel.org, Bodo Stroesser , "Martin K . Petersen" , Yanko Kaneti References: <20210805043503.20252-1-bvanassche@acm.org> <20210805043503.20252-4-bvanassche@acm.org> <20210809145953.GB21234@lst.de> From: Bart Van Assche Message-ID: Date: Tue, 10 Aug 2021 20:13:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/10/21 3:00 PM, Brendan Higgins wrote: > On Mon, Aug 9, 2021 at 7:59 AM Christoph Hellwig wrote: >> >>> text and binary attribute support. This is how I run these tests: >>> >>> set -e >>> if [ -e .config ]; then >>> make ARCH=um mrproper >>> fi >>> if [ ! -e .kunit/.kunitconfig ]; then >>> cat <.kunit/.kunitconfig >>> CONFIG_CONFIGFS_FS=y >>> CONFIG_CONFIGFS_KUNIT_TEST=y >>> CONFIG_KUNIT=y >>> CONFIG_PROVE_LOCKING=y >>> CONFIG_SYSFS=y >>> CONFIG_UBSAN=y >>> EOF >>> cp .kunit/.kunitconfig .kunit/.config >>> fi >>> ./tools/testing/kunit/kunit.py run >> >> This is very useful documentation, but shouldn't it go into a README.kunit >> or similar instead of a commit message? > > You could also put this in a .kunitconfig specific to your subsystem > like we did for ext4: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/.kunitconfig > > You can then build using this .kunitconfig with something like: > > ./tools/testing/kunit/kunit.py run --kunitconfig=fs/ext4/.kunitconfig Will look into this. Thanks for the feedback! Bart.