From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53098C4320A for ; Fri, 30 Jul 2021 09:46:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35C0660E09 for ; Fri, 30 Jul 2021 09:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238276AbhG3JqH convert rfc822-to-8bit (ORCPT ); Fri, 30 Jul 2021 05:46:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238149AbhG3JqE (ORCPT ); Fri, 30 Jul 2021 05:46:04 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 269E4C0613C1 for ; Fri, 30 Jul 2021 02:45:57 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9P5U-0007Fl-DW; Fri, 30 Jul 2021 11:45:52 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1m9P5T-0000A9-03; Fri, 30 Jul 2021 11:45:51 +0200 Message-ID: Subject: Re: [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset controller From: Philipp Zabel To: Anand Moon , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org Cc: Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Rob Herring , Kevin Hilman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Emiliano Ingrassia Date: Fri, 30 Jul 2021 11:45:50 +0200 In-Reply-To: <20210729201100.3994-3-linux.amoon@gmail.com> References: <20210729201100.3994-1-linux.amoon@gmail.com> <20210729201100.3994-3-linux.amoon@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > Used new reset id for reset controller as it conflict > with the core reset id. > > Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description") > > Cc: Jerome Brunet > Cc: Neil Armstrong > Cc: Martin Blumenstingl > Signed-off-by: Anand Moon > --- > arch/arm/boot/dts/meson8b.dtsi | 2 +- > arch/arm/boot/dts/meson8m2.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi > index c02b03cbcdf4..cb3a579d09ef 100644 > --- a/arch/arm/boot/dts/meson8b.dtsi > +++ b/arch/arm/boot/dts/meson8b.dtsi > @@ -511,7 +511,7 @@ ðmac { > tx-fifo-depth = <2048>; > > resets = <&reset RESET_ETHERNET>; > - reset-names = "stmmaceth"; > + reset-names = "ethreset"; This looks like an incompatible change. Is the "stmmaceth" reset not used? It is documented as "MAC reset signal" in [1]. So a PHY reset should be separate from this. [1] Documentation/devicetree/bindings/net/snps,dwmac.yaml regards Philipp