LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	mchehab@kernel.org, sean@mess.org
Subject: Re: [PATCH v2] drivers/media/dvb-frontends: Implement probe/remove for stv6110x
Date: Wed, 29 May 2019 21:20:37 -0700	[thread overview]
Message-ID: <a47d7093b10d671ae89fa6f6962d69d6913a30f7.camel@perches.com> (raw)
In-Reply-To: <d1afd4d3-0dc5-718d-f7b4-f763f367ca1e@mni.thm.de>

On Wed, 2019-05-29 at 21:03 +0200, Tobias Klausmann wrote:
> thanks for the comments! If really desired i can change the code 
> further, adapting to your comments, but note that the code was 
> essentially just moved around to cater to both _probe() and attach(), 
> intentionally leaving it as it was before the patch!

Up to you.
My general preference is for human intelligible and simple code.


      reply	other threads:[~2019-05-30  4:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 19:51 [PATCH] " Tobias Klausmann
2019-05-12 14:53 ` Tobias Klausmann
2019-05-26  9:33   ` Sean Young
2019-05-26 13:11     ` Tobias Klausmann
2019-05-29 16:56 ` [PATCH v2] " Tobias Klausmann
2019-05-29 18:45   ` Joe Perches
2019-05-29 19:03     ` Tobias Klausmann
2019-05-30  4:20       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a47d7093b10d671ae89fa6f6962d69d6913a30f7.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sean@mess.org \
    --cc=tobias.johannes.klausmann@mni.thm.de \
    --subject='Re: [PATCH v2] drivers/media/dvb-frontends: Implement probe/remove for stv6110x' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).