LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org
Subject: Re: [PATCH v2 4/9] sched/topology: Kill SD_LOAD_BALANCE
Date: Thu, 19 Mar 2020 11:29:25 +0100 [thread overview]
Message-ID: <a4a87ce6-9770-dc58-c2b6-e001b8050a8e@arm.com> (raw)
In-Reply-To: <20200311181601.18314-5-valentin.schneider@arm.com>
On 11.03.20 19:15, Valentin Schneider wrote:
> That flag is set unconditionally in sd_init(), and no one checks for it
> anymore. Remove it.
Why not merge 3/9 and 4/9 ?
[...]
> diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h
> index f341163fedc9..8de2f9744569 100644
> --- a/include/linux/sched/topology.h
> +++ b/include/linux/sched/topology.h
> @@ -11,21 +11,20 @@
> */
> #ifdef CONFIG_SMP
>
> -#define SD_LOAD_BALANCE 0x0001 /* Do load balancing on this domain. */
> -#define SD_BALANCE_NEWIDLE 0x0002 /* Balance when about to become idle */
[...]
> -#define SD_OVERLAP 0x2000 /* sched_domains of this level overlap */
> -#define SD_NUMA 0x4000 /* cross-node balancing */
> +#define SD_BALANCE_NEWIDLE 0x0001 /* Balance when about to become idle */
IMHO, changing the values of the remaining SD flags will break lots of
userspace scripts.
[...]
next prev parent reply other threads:[~2020-03-19 10:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 18:15 [PATCH v2 0/9] sched: Streamline select_task_rq() & select_task_rq_fair() Valentin Schneider
2020-03-11 18:15 ` [PATCH v2 1/9] sched/fair: find_idlest_group(): Remove unused sd_flag parameter Valentin Schneider
2020-03-19 9:05 ` Dietmar Eggemann
2020-03-11 18:15 ` [PATCH v2 2/9] sched/debug: Make sd->flags sysctl read-only Valentin Schneider
2020-03-19 9:07 ` Dietmar Eggemann
2020-03-19 12:04 ` Valentin Schneider
2020-03-11 18:15 ` [PATCH v2 3/9] sched: Remove checks against SD_LOAD_BALANCE Valentin Schneider
2020-03-19 10:28 ` Dietmar Eggemann
2020-03-19 12:05 ` Valentin Schneider
2020-03-23 14:26 ` Dietmar Eggemann
2020-03-23 17:17 ` Valentin Schneider
2020-03-11 18:15 ` [PATCH v2 4/9] sched/topology: Kill SD_LOAD_BALANCE Valentin Schneider
2020-03-19 10:29 ` Dietmar Eggemann [this message]
2020-03-19 12:06 ` Valentin Schneider
2020-03-11 18:15 ` [PATCH v2 5/9] sched: Add WF_TTWU, WF_EXEC wakeup flags Valentin Schneider
2020-03-11 18:15 ` [PATCH v2 6/9] sched: Kill select_task_rq()'s sd_flag parameter Valentin Schneider
2020-03-11 18:15 ` [PATCH v2 7/9] sched/fair: Dissociate wakeup decisions from SD flag value Valentin Schneider
2020-03-11 18:16 ` [PATCH v2 8/9] sched/fair: Split select_task_rq_fair want_affine logic Valentin Schneider
2020-03-19 10:30 ` Dietmar Eggemann
2020-03-19 12:06 ` Valentin Schneider
2020-03-11 18:16 ` [PATCH v2 9/9] sched/topology: Define and use shortcut pointers for wakeup sd_flag scan Valentin Schneider
2020-03-19 10:46 ` Dietmar Eggemann
2020-03-19 12:22 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a87ce6-9770-dc58-c2b6-e001b8050a8e@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--subject='Re: [PATCH v2 4/9] sched/topology: Kill SD_LOAD_BALANCE' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).