From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9F6C4332D for ; Thu, 19 Mar 2020 10:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F01B20722 for ; Thu, 19 Mar 2020 10:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbgCSK3i (ORCPT ); Thu, 19 Mar 2020 06:29:38 -0400 Received: from foss.arm.com ([217.140.110.172]:33030 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726785AbgCSK3h (ORCPT ); Thu, 19 Mar 2020 06:29:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6BF7D31B; Thu, 19 Mar 2020 03:29:37 -0700 (PDT) Received: from [192.168.1.19] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 719903F305; Thu, 19 Mar 2020 03:29:36 -0700 (PDT) From: Dietmar Eggemann Subject: Re: [PATCH v2 4/9] sched/topology: Kill SD_LOAD_BALANCE To: Valentin Schneider , linux-kernel@vger.kernel.org Cc: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org References: <20200311181601.18314-1-valentin.schneider@arm.com> <20200311181601.18314-5-valentin.schneider@arm.com> Message-ID: Date: Thu, 19 Mar 2020 11:29:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200311181601.18314-5-valentin.schneider@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.03.20 19:15, Valentin Schneider wrote: > That flag is set unconditionally in sd_init(), and no one checks for it > anymore. Remove it. Why not merge 3/9 and 4/9 ? [...] > diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h > index f341163fedc9..8de2f9744569 100644 > --- a/include/linux/sched/topology.h > +++ b/include/linux/sched/topology.h > @@ -11,21 +11,20 @@ > */ > #ifdef CONFIG_SMP > > -#define SD_LOAD_BALANCE 0x0001 /* Do load balancing on this domain. */ > -#define SD_BALANCE_NEWIDLE 0x0002 /* Balance when about to become idle */ [...] > -#define SD_OVERLAP 0x2000 /* sched_domains of this level overlap */ > -#define SD_NUMA 0x4000 /* cross-node balancing */ > +#define SD_BALANCE_NEWIDLE 0x0001 /* Balance when about to become idle */ IMHO, changing the values of the remaining SD flags will break lots of userspace scripts. [...]