LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com,
	tglx@linutronix.de, akpm@linux-foundation.org,
	kernel@gpiccoli.net
Subject: Re: [PATCH] panic: Add sysctl/cmdline to dump all CPUs backtraces on oops event
Date: Mon, 16 Mar 2020 10:51:22 -0300	[thread overview]
Message-ID: <a4f5bff0-82c8-114e-0386-9d44baa3cfac@canonical.com> (raw)
In-Reply-To: <43c0e375-6ed1-6a4e-1d61-c0255bf94f26@infradead.org>

On 14/03/2020 18:18, Randy Dunlap wrote:
> On 3/14/20 7:28 AM, Matthew Wilcox wrote:
>> On Tue, Mar 10, 2020 at 01:59:15PM -0700, Randy Dunlap wrote:
>>>> +oops_all_cpu_backtrace:
>>>> +================
>>>> +
>>>> +Determines if kernel should NMI all CPUs to dump their backtraces when
>>>
>>> I would much prefer that to be written without using NMI as a verb.
>>
>> Concrete suggestion: "If this option is set, the kernel will send an NMI to
>> all CPUs to dump ..."
>>
> 
> Ack.  Thanks for that.
> 

Thanks Randy and Matthew! I'll implement those changes and resend as V2.
If anybody has suggestions of people I should add to CC list, please let
me know.

Thanks again,


Guilherme

      reply	other threads:[~2020-03-16 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 16:37 Guilherme G. Piccoli
2020-03-10 20:59 ` Randy Dunlap
2020-03-11  1:26   ` Andrew Morton
2020-03-11 12:46     ` Guilherme G. Piccoli
2020-03-14 14:28   ` Matthew Wilcox
2020-03-14 21:18     ` Randy Dunlap
2020-03-16 13:51       ` Guilherme G. Piccoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4f5bff0-82c8-114e-0386-9d44baa3cfac@canonical.com \
    --to=gpiccoli@canonical.com \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=kernel@gpiccoli.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --cc=yzaikin@google.com \
    --subject='Re: [PATCH] panic: Add sysctl/cmdline to dump all CPUs backtraces on oops event' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).