LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Steve French <smfrench@gmail.com>, Andreas Dilger <adilger@dilger.ca>
Cc: Eric Biggers <ebiggers3@gmail.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	samba-technical <samba-technical@lists.samba.org>,
	CIFS <linux-cifs@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: copy_file_range and user space tools to do copy fastest
Date: Sat, 28 Apr 2018 08:59:27 -0500	[thread overview]
Message-ID: <a5f51dba-0673-9ef7-6705-e9690f8e6f4e@suse.de> (raw)
In-Reply-To: <CAH2r5mv7nxfgdr_rgk6oRLPN9UhXKDnU6n1PP9hu6r-X1E+iHg@mail.gmail.com>



On 04/28/2018 12:26 AM, Steve French wrote:
> On Sat, Apr 28, 2018 at 12:18 AM, Andreas Dilger <adilger@dilger.ca> wrote:
>> On Apr 27, 2018, at 5:41 PM, Eric Biggers <ebiggers3@gmail.com> wrote:
>>>
>>> On Fri, Apr 27, 2018 at 01:45:40PM -0600, Andreas Dilger wrote:
>>>> On Apr 27, 2018, at 12:25 PM, Steve French <smfrench@gmail.com> wrote:
>>>>>
>>>>> Are there any user space tools (other than our test tools and xfs_io
>>>>> etc.) that support copy_file_range?  Looks like at least cp and rsync
>>>>> and dd don't.  That syscall which now has been around a couple years,
>>>>> and was reminded about at the LSF/MM summit a few days ago, presumably
>>>>> is the 'best' way to copy a file fast since it tries all the
>>>>> mechanisms (reflink etc.) in order.
>>>>>
>>>>> Since copy_file_range syscall can be 100x or more faster for network
>>>>> file systems than the alternative, was surprised when I noticed that
>>>>> cp and rsync didn't support it.  It doesn't look like rsync even
>>>>> supports reflink either(although presumably if you call
>>>>> copy_file_range you don't have to worry about that), and reads/writes
>>>>> are 8K. See copy_file() in rsync/util.c
>>>>>
>>>>> In the cp command it looks like it can call the FICLONE IOCTL (see
>>>>> clone_file() in coreutils/src/copy.c) but doesn't call the expected
>>>>> "copy_file_range" syscall.
>>>>>
>>>>> In the dd command it doesn't call either - see dd_copy in corutils/src/dd.c
>>>>>
>>>>> Since it can be 100x or more faster in some cases to call
>>>>> copy_file_range than do reads/writes back and forth to do a copy
>>>>> (especially if network or clustered backend or cloud), what tools are
>>>>> the best to recommend?
>>>>>
>>>>> Would rsync or cp be likely to take patches to call the standard
>>>>> "copy_file_range" syscall
>>>>> (http://man7.org/linux/man-pages/man2/copy_file_range.2.html)?
>>>>> Presumably not if it has been two+ years ... but would be interested
>>>>> what copy tools to recommend to use instead.
>>>>
>>>> I would start with submitting a patch to coreutils, if you can figure
>>>> out that code enough to do so (I find it quite opaque).  Since it has
>>>> been in the kernel for a while already, it should be acceptable to the
>>>> upstream coreutils maintainers to use this interface.  Doubly so if you
>>>> include some benchmarks with CIFS/NFS clients avoiding network overhead
>>>> during the copy.
>>>>
>>>
>>> For cp (coreutils), apparently there was a concern that copy_file_range()
>>> expands holes; see the thread at
>>> https://lists.gnu.org/archive/html/bug-coreutils/2016-09/msg00020.html.
>>> Though, I'd think it could just be used on non-holes only.  And I don't think
>>> the size_t type of 'len' is a problem either, since it's the copy length, not
>>> the file size.  You just call it multiple times if the file is larger.
>>
>> I think cp is already using SEEK_HOLE/SEEK_DATA and/or FIEMAP to determine
>> the mapped and sparse segments of the file, so it should be practical to
>> use copy_file_range() in conjunction with these to copy only the allocated
>> parts of the file.
> 
> For the case where clone/reflink or copy_file_range is supported - is
> there any reason to
> not sent the request to copy the whole file? Presumably long
> timeout/errors might be a concern, but
> that could happen with ranges too.  In any case, if sent the whole
> file copy request,
> the server file system can figure out the  holes and copy more efficiently.
> 
> In the case where it is copying local to remote or remote to local -
> figuring out whether it is
> sparse and optimizing makes a lot of sense - but I didn't think cp did
> that (at least the
> sections of code I was looking at).

cp does check for sparse files and tries to recreate them depending on
--sparse=WHEN option. Check the make_holes variable in copy.c. However,
we could still use copy_file_range() when make_holes is false and close
on success. However, you would have to be careful to check if the return
value is positive and less than len and have to act accordingly.

-- 
Goldwyn

      reply	other threads:[~2018-04-28 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 18:25 Steve French
2018-04-27 19:45 ` Andreas Dilger
2018-04-27 23:41   ` Eric Biggers
2018-04-28  5:18     ` Andreas Dilger
2018-04-28  5:26       ` Steve French
2018-04-28 13:59         ` Goldwyn Rodrigues [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5f51dba-0673-9ef7-6705-e9690f8e6f4e@suse.de \
    --to=rgoldwyn@suse.de \
    --cc=adilger@dilger.ca \
    --cc=ebiggers3@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    --subject='Re: copy_file_range and user space tools to do copy fastest' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).