LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Gianfranco Costamagna <locutusofborg@debian.org>
To: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>,
	dvhart@infradead.org
Cc: andy@infradead.org, vger@kernel.org,
	linux-kernel@vger.kernel.org, Chris Chiu <chiu@endlessm.com>,
	Daniel Drake <drake@endlessm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode
Date: Sat, 21 Apr 2018 20:40:40 +0200	[thread overview]
Message-ID: <a62dded5-0fa9-1a6e-dd71-3e03cc311f1f@debian.org> (raw)
In-Reply-To: <20180420212641.30338-1-antonio.intilisano@gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello,

On 20/04/2018 23:26, Antonio Rosario Intilisano wrote:
>     Now that we have informed the firmware that the Power Button driver is
>     active, laptops such as the Acer Swift 3 will generate
>     a WMI key event with code 0x87 when the power button key is
>     pressed. 
>     
>     Add this keycode to the table so that it is converted to an appropriate
>     input event.
> 

I don't know why Acer folks didn't merge this into the kernel yet, but this patch
seems to fix a real issue, so I'm thinking about uploading it in Ubuntu right now.

Antonio, I forgot to tell you before, can you please open an Ubuntu bug so we can track the change?
(ubuntu-bug linux should do the trick)

Gianfranco

> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
> Cc: Chris Chiu <chiu@endlessm.com>
> Cc: Daniel Drake <drake@endlessm.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f956d5c..8952173dd380 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { 	{KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>  	{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>  	{KE_KEY, 0x86, {KEY_WLAN} },
> +	{KE_KEY, 0x87, {KEY_POWER} },
>  	{KE_END, 0}
>  };
>  
> 

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJa24WoAAoJEPNPCXROn13Zih8P/R8TOet5JdpAqdu9o/YUjP6b
iBhygp3rPJgXjzEnGtHvrukzu1MviL82iE1evelbUrmNuT6/aw++PabZ89rTzGwE
TVGJcjG6gl05UjCLjNE9G0xscb0aj3+bLf7ogZ+boUrjOU0xpZrutlGwh7XhSd26
sp+3PnkxccnLI6rSLXOVZqB3JaDa5+QJRlb/NudboawHp5dH4QiYdcHv/lOiKIh4
3ur+HaMfDannMQDzwN5FMWrP5jepjsEPq7R5D0QkUc/ivY6Nod7722aKU8Vilxol
tPPcUHWm/fGjYM4AGp8z1zH31FUCWyJjg404Ncb5AOcnoV2iVwN6KZkCM/WSjtwu
R+G2tYy2cX6DPqK5jUw5LyriA595DkpsHUa3p13nm0NhgpkM6EQT787AlTn6QJqQ
/MAJBfwRYuqc7+aG2CWg4OpKjFn6v8wfh2wEa6sMcbsemaqL9ct1ZS6NzNHAbuNS
BJRyuEnrmrQ9DEkPoLUo7pK1zeCNT5M0PkQy4BIPxD7FLh7IFVr24kOrUw6zq6sL
MomvE37pfqAb3FBWsVch32ERrBhA+8nBjl17j54F9N2DUfl1ZL6ZvIL77ah1ZpY1
7oBMDKpYwJbL36uDV7vXOO3FlO1vUjUMckmEer2lDskbZyFazYTRF4aUTS6uvAWJ
R9QJxPQbHC339wL5tEDm
=qQE6
-----END PGP SIGNATURE-----

  reply	other threads:[~2018-04-21 18:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 21:26 Antonio Rosario Intilisano
2018-04-21 18:40 ` Gianfranco Costamagna [this message]
2018-04-23 14:06   ` Andy Shevchenko
2018-04-23 14:48     ` Gianfranco Costamagna
2018-04-24 16:15       ` Andy Shevchenko
2018-04-24 17:02         ` Andy Shevchenko
2018-04-24 18:23           ` Gianfranco Costamagna
2018-04-24 18:33             ` Andy Shevchenko
2018-04-20 21:32 Antonio Rosario Intilisano
2018-04-27 21:50 Antonio Rosario Intilisano
2018-05-07 14:08 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a62dded5-0fa9-1a6e-dd71-3e03cc311f1f@debian.org \
    --to=locutusofborg@debian.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@infradead.org \
    --cc=antonio.intilisano@gmail.com \
    --cc=chiu@endlessm.com \
    --cc=drake@endlessm.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vger@kernel.org \
    --subject='Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).