LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dave Young" <hidave.darkstar@gmail.com>
To: "Jarek Poplawski" <jarkao2@gmail.com>
Cc: gregkh@suse.de, stern@rowland.harvard.edu, peterz@infradead.org,
	david-b@pacbell.net, davem@davemloft.net, krh@redhat.com,
	stefanr@s5r6.in-berlin.de, dbrownell@users.sourceforge.net,
	James.Bottomley@hansenpartnership.com, a.zummo@towertech.it,
	cbou@mail.ru, dwmw2@infradead.org, khali@linux-fr.org,
	i2c@lm-sensors.org, linux1394-devel@lists.sourceforge.net,
	spi-devel-general@lists.sourceforge.net,
	linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class
Date: Thu, 3 Jan 2008 15:21:36 +0800	[thread overview]
Message-ID: <a8e1da0801022321u236d5f23ub6b5b8b61ebea505@mail.gmail.com> (raw)
In-Reply-To: <20080103072404.GB1677@ff.dom.local>

On Jan 3, 2008 3:24 PM, Jarek Poplawski <jarkao2@gmail.com> wrote:
> On Thu, Jan 03, 2008 at 08:06:09AM +0100, Jarek Poplawski wrote:
> > On Thu, Jan 03, 2008 at 01:50:20PM +0800, Dave Young wrote:
> > > Convert semaphore to mutex in struct class.
> > ...
> > > One lockdep warning detected as following, thus use mutex_lock_nested with SINGLE_DEPTH_NESTING in class_device_add
> > >
> > > Jan  3 10:45:15 darkstar kernel: =============================================
> > > Jan  3 10:45:15 darkstar kernel: [ INFO: possible recursive locking detected ]
> > > Jan  3 10:45:15 darkstar kernel: 2.6.24-rc6-mm1-mutex #1
> > > Jan  3 10:45:15 darkstar kernel: ---------------------------------------------
> > ...
> > > If there's anything missed please help to point out, thanks.
> >
> > Dave, IMHO it's not 'the right' way to do it: [...]
>
> OOPS! (I was sleeping...) Unless it has turned out it's not so hard
> here, and you are quite sure there should be no more warnings after
> this one nesting annotation - then of course, this is the right way!

Thanks ;)
I don't know if there's other possible warning places with this mutex
or not,  if you have any ideas about this, please tell me.

>
> Sorry (?)
> Jarek P.
>

  reply	other threads:[~2008-01-03  7:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03  5:50 Dave Young
2008-01-03  7:06 ` Jarek Poplawski
2008-01-03  7:24   ` Jarek Poplawski
2008-01-03  7:21     ` Dave Young [this message]
2008-01-03  7:41       ` Jarek Poplawski
2008-01-06 18:41 ` Stefan Richter
2008-01-07  2:09   ` Dave Young
2008-01-07  8:45     ` Greg KH
2008-01-07  9:01       ` David Brownell
2008-01-07 13:23         ` Stefan Richter
2008-01-07 14:00           ` Jarek Poplawski
2008-01-07 16:36             ` Stefan Richter
2008-01-07 15:44           ` Greg KH
2008-01-07 17:13             ` Stefan Richter
2008-01-07 17:20               ` Greg KH
2008-01-08  7:05                 ` Dave Young
2008-01-08 22:48                   ` Greg KH
2008-01-09  1:32                     ` Dave Young
2008-01-09  6:13                       ` Dave Young
2008-01-09  6:37                         ` Dave Young
2008-01-09  6:39                           ` Dave Young
2008-01-10  9:48                             ` Dave Young
2008-01-10 12:34                               ` Stefan Richter
2008-01-11  2:18                                 ` Dave Young
2008-01-10 13:23                               ` Cornelia Huck
2008-01-11  2:33                                 ` Dave Young
2008-01-11  8:23                                   ` Cornelia Huck
2008-01-11  8:53                                     ` Dave Young
2008-01-10 15:41                               ` Alan Stern
2008-01-11  2:37                                 ` Dave Young
2008-01-10 18:39                               ` Greg KH
2008-01-11  2:40                                 ` Dave Young
2008-01-07 17:25               ` Alan Stern
2008-01-07 10:00       ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0801022321u236d5f23ub6b5b8b61ebea505@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=a.zummo@towertech.it \
    --cc=cbou@mail.ru \
    --cc=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=i2c@lm-sensors.org \
    --cc=jarkao2@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=peterz@infradead.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [PATCH 0/7] convert semaphore to mutex in struct class' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).