LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dave Young" <hidave.darkstar@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Alon Bar-Lev" <alon.barlev@gmail.com>,
	linux-kernel@vger.kernel.org, marcel@holtmann.org,
	bluez-devel@lists.sourceforge.net
Subject: Re: [BUG] rfcomm
Date: Sat, 16 Feb 2008 07:13:49 +0800	[thread overview]
Message-ID: <a8e1da0802151513p34ad118i54ddd8f00e6e136@mail.gmail.com> (raw)
In-Reply-To: <a8e1da0802141928yabfd87ajfed0b009e1e79018@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5365 bytes --]

On Fri, Feb 15, 2008 at 11:28 AM, Dave Young <hidave.darkstar@gmail.com> wrote:
>
> On Wed, Feb 13, 2008 at 3:58 PM, Andrew Morton
>  <akpm@linux-foundation.org> wrote:
>  > On Mon, 11 Feb 2008 17:57:54 +0200 Alon Bar-Lev <alon.barlev@gmail.com> wrote:
>  >
>  >  > On Tuesday 06 November 2007, Alon Bar-Lev wrote:
>  >  > > On 11/6/07, Dave Young <hidave.darkstar@gmail.com> wrote:
>  >  > > > Hi,
>  >  > > > sorry for reply again, this seems a diffrent issue ...
>  >  > >
>  >  > > All that I do is running pppd over the rfcomm, suspending the system and resume.
>  >  > > I don't load any binary module.
>  >  > >
>  >  > > Alon.
>  >  > >
>  >  >
>  >  > Tried 2.6.24.1...
>  >  > PLEASE fix this.
>  >  > Thanks!
>  >  >
>  >  > ---
>  >  >
>  >  > Feb 11 17:46:05 alon1 Restarting tasks ... <6>usb 2-1: USB disconnect, address 10
>  >  > Feb 11 17:46:05 alon1 done.
>  >  > Feb 11 17:46:05 alon1 usb 3-1: USB disconnect, address 7
>  >  > Feb 11 17:46:05 alon1 usb 3-2: USB disconnect, address 6
>  >  > Feb 11 17:46:05 alon1 usb 3-1: new full speed USB device using uhci_hcd and address 8
>  >  > Feb 11 17:46:05 alon1 usb 3-1: configuration #1 chosen from 1 choice
>  >  > Feb 11 17:46:05 alon1 BUG: unable to handle kernel NULL pointer dereference at virtual address 00000008
>  >  > Feb 11 17:46:05 alon1 printing eip: c01b2da6 *pde = 00000000
>  >  > Feb 11 17:46:05 alon1 Oops: 0000 [#1] PREEMPT
>  >  > Feb 11 17:46:05 alon1 Modules linked in: aes_generic crypto_algapi ieee80211_crypt_ccmp ppp_deflate zlib_deflate zlib_inflate bsd_comp ppp_async thinkpad_acpi hwmon nvram vmnet(P) vmmon(P) tun radeon drm autofs4 ipv6 nf_nat_irc nf_nat_ftp nf_conntrack_irc nf_conntrack_ftp ipt_MASQUERADE iptable_nat nf_nat ipt_REJECT xt_tcpudp ipt_LOG xt_limit xt_state nf_conntrack_ipv4 nf_conntrack iptable_filter ip_tables x_tables rfcomm l2cap snd_pcm_oss snd_mixer_oss snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device ppp_generic slhc ioatdma dca cfq_iosched cpufreq_powersave cpufreq_ondemand cpufreq_conservative acpi_cpufreq freq_table uinput fan af_packet nls_cp1255 nls_iso8859_1 nls_utf8 nls_base hci_usb bluetooth pcmcia snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm ipw2200 nsc_ircc snd_timer irda ieee80211 snd psmouse yenta_socket ehci_hcd pcspkr ieee80211_crypt e1000 rsrc_nonstatic uhci_hcd soundcore i2c_i801 intel_agp crc_ccitt thermal sr_mod pcmcia_core snd_page_al!
>  >   lo!
>  >
>  >
>  > >  c battery rtc firmware_class agpgart ac processor cdrom sg button unix usbcore evdev ext3 jbd ext2 mbcache loop ata_piix libata sd_mod scsi_mod
>  >  > Feb 11 17:46:05 alon1
>  >  > Feb 11 17:46:05 alon1 Pid: 4, comm: events/0 Tainted: P        (2.6.24-gentoo-r1 #1)
>  >  > Feb 11 17:46:05 alon1 EIP: 0060:[<c01b2da6>] EFLAGS: 00010286 CPU: 0
>  >  > Feb 11 17:46:05 alon1 EIP is at sysfs_get_dentry+0x26/0x80
>  >  > Feb 11 17:46:05 alon1 EAX: 00000000 EBX: 00000000 ECX: 00000000 EDX: ebf21000
>  >  > Feb 11 17:46:05 alon1 ESI: eab4e880 EDI: f713bb40 EBP: f713bb40 ESP: f7c49f00
>  >  > Feb 11 17:46:05 alon1 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
>  >  > Feb 11 17:46:05 alon1 Process events/0 (pid: 4, ti=f7c48000 task=f7c3efc0 task.ti=f7c48000)
>  >  > Feb 11 17:46:05 alon1 Stack: f7c97120 f7135a68 f7e71e10 c01b303d ffffffff ffffffff fffffffe c030ba9c
>  >  > Feb 11 17:46:05 alon1 f7c97120 f7135a68 f2fefb40 f7c97120 f7135a68 f2fefb40 c030ba8e c01ce1fb
>  >  > Feb 11 17:46:05 alon1 f75f1b00 c030ba8e f2fefb40 f75f1b00 f75f1b00 00000000 f7135a00 00000000
>  >  > Feb 11 17:46:05 alon1 Call Trace:
>  >  > Feb 11 17:46:05 alon1 [<c01b303d>] sysfs_move_dir+0x3d/0x1f0
>  >  > Feb 11 17:46:05 alon1 [<c01ce1fb>] kobject_move+0x9b/0x120
>  >  > Feb 11 17:46:05 alon1 [<c0241701>] device_move+0x51/0x110
>  >  > Feb 11 17:46:05 alon1 [<f9a8adb0>] del_conn+0x0/0x40 [bluetooth]
>  >  > Feb 11 17:46:05 alon1 [<f9a8adc0>] del_conn+0x10/0x40 [bluetooth]
>  >  > Feb 11 17:46:05 alon1 [<c012c1a1>] run_workqueue+0x81/0x140
>  >  > Feb 11 17:46:05 alon1 [<c02c0c78>] schedule+0x168/0x2e0
>  >  > Feb 11 17:46:05 alon1 [<c012fc70>] autoremove_wake_function+0x0/0x50
>  >  > Feb 11 17:46:05 alon1 [<c012c9cb>] worker_thread+0x9b/0xf0
>  >  > Feb 11 17:46:05 alon1 [<c012fc70>] autoremove_wake_function+0x0/0x50
>  >  > Feb 11 17:46:05 alon1 [<c012c930>] worker_thread+0x0/0xf0
>  >  > Feb 11 17:46:05 alon1 [<c012f962>] kthread+0x42/0x70
>  >  > Feb 11 17:46:05 alon1 [<c012f920>] kthread+0x0/0x70
>  >  > Feb 11 17:46:05 alon1 [<c0104c2f>] kernel_thread_helper+0x7/0x18
>  >  > Feb 11 17:46:05 alon1 =======================
>  >  > Feb 11 17:46:05 alon1 Code: 26 00 00 00 00 57 89 c7 a1 50 1b 3a c0 56 53 8b 70 38 85 f6 74 08 8b 0e 85 c9 74 58 ff 06 8b 56 50 39 fa 74 47 89 fb eb 02 89 c3 <8b> 43 08 39 c2 75 f7 8b 46 08 83 c0 68 e8 98 e7 10 00 8b 43 10
>  >  > Feb 11 17:46:05 alon1 EIP: [<c01b2da6>] sysfs_get_dentry+0x26/0x80 SS:ESP 0068:f7c49f00
>  >
>  >  A number of bluetooth fixes went into 2.6.25-rc1.  It would be interestig
>  >  to see if we fixed this.
>  >
>  >
>
>  Seems there's some bugs about suspend/resume bluetooth devices.
>  I cannot produce the above bug, but my bluetooth dongle does'nt work
>  as normal  when I tying s2ram
>
>  Another similar report:
>  http://lkml.org/lkml/2008/2/13/701

Hi, alon

Please try the attached patch, hope it fixes your problem.

Regards
dave
>
>  Regards
>  dave
>

[-- Attachment #2: diff --]
[-- Type: application/octet-stream, Size: 1340 bytes --]

Signed-off-by: Dave Young <hidave.darkstar@gmail.com> 

---
net/bluetooth/hci_conn.c  |    1 -
net/bluetooth/hci_sysfs.c |    5 ++++-
2 files changed, 4 insertions(+), 2 deletions(-)

diff -upr linux/net/bluetooth/hci_conn.c linux.new/net/bluetooth/hci_conn.c
--- linux/net/bluetooth/hci_conn.c	2008-02-16 06:38:56.000000000 +0800
+++ linux.new/net/bluetooth/hci_conn.c	2008-02-16 06:54:17.000000000 +0800
@@ -260,7 +260,6 @@ int hci_conn_del(struct hci_conn *conn)
 	tasklet_enable(&hdev->tx_task);
 	skb_queue_purge(&conn->data_q);
 	hci_conn_del_sysfs(conn);
-	hci_dev_put(hdev);
 
 	return 0;
 }
diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c
--- linux/net/bluetooth/hci_sysfs.c	2008-02-16 06:38:56.000000000 +0800
+++ linux.new/net/bluetooth/hci_sysfs.c	2008-02-16 06:54:17.000000000 +0800
@@ -333,15 +333,18 @@ static int __match_tty(struct device *de
 
 static void del_conn(struct work_struct *work)
 {
-	struct device *dev;
 	struct hci_conn *conn = container_of(work, struct hci_conn, work);
+	struct hci_dev *hdev = conn->hdev;
+	struct device *dev;
 
 	while (dev = device_find_child(&conn->dev, NULL, __match_tty)) {
 		device_move(dev, NULL);
 		put_device(dev);
 	}
+
 	device_del(&conn->dev);
 	put_device(&conn->dev);
+	hci_dev_put(hdev);
 }
 
 void hci_conn_del_sysfs(struct hci_conn *conn)

  reply	other threads:[~2008-02-15 23:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 17:50 [BUG] rfcomm] Alon Bar-Lev
2007-10-23 17:55 ` Marcel Holtmann
2007-10-23 17:57   ` Alon Bar-Lev
2007-10-23 18:26     ` Marcel Holtmann
2007-10-23 18:28       ` Alon Bar-Lev
2007-10-23 22:10     ` Rafael J. Wysocki
2007-10-23 18:06   ` Jiri Kosina
2007-10-23 18:25     ` Marcel Holtmann
2007-10-23 18:27       ` Alon Bar-Lev
2007-10-23 18:30         ` Marcel Holtmann
2007-10-23 18:55           ` Alon Bar-Lev
2007-10-24  8:43             ` Cornelia Huck
2007-10-23 18:28       ` Jiri Kosina
2007-10-24  9:56         ` Pavel Machek
2007-11-05  5:08 ` [Bluez-devel] " Dave Young
2007-11-05 15:46   ` Alon Bar-Lev
2007-11-06  1:48     ` Dave Young
2007-11-06  2:49       ` Dave Young
2007-11-06  5:49         ` Alon Bar-Lev
2008-02-11 15:57           ` [BUG] rfcomm Alon Bar-Lev
2008-02-11 22:48             ` Frederik Deweerdt
2008-02-13  7:58             ` Andrew Morton
2008-02-13 16:58               ` Mark Lord
2008-02-15  3:28               ` Dave Young
2008-02-15 23:13                 ` Dave Young [this message]
2008-02-16 21:49                   ` Alon Bar-Lev
2008-02-20 10:36                     ` Dave Young
2008-02-20 11:16                       ` [Bluez-devel] " Stefan Seyfried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0802151513p34ad118i54ddd8f00e6e136@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alon.barlev@gmail.com \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --subject='Re: [BUG] rfcomm' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).